[haiku-commits] haiku: hrev56162 - src/libs/compat/freebsd_network

  • From: waddlesplash <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 7 Jun 2022 18:44:10 +0000 (UTC)

hrev56162 adds 1 changeset to branch 'master'
old head: c146183167273258c790ed24e6fa6b26c8fd8bbf
new head: 1cef8ebf6ec3e7ac63b292c53cc6f80f4e2b8a81
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=1cef8ebf6ec3+%5Ec14618316727

----------------------------------------------------------------------------

1cef8ebf6ec3: freebsd_network: Fix ticks check in callout_reset.
  
  "ticks" is the name of the global variable indicating time since
  system start; "_ticks" is the local variable. The confusion between
  the two caused every callout to be invoked as soon as it was instantiated.
  
  I am pretty surprised this was not noticed before. I only discovered
  it just now while working on the OpenBSD WiFi driver ports. Seems
  it has been broken like this for multiple years...

                              [ Augustin Cavalier <waddlesplash@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev56162
Commit:      1cef8ebf6ec3e7ac63b292c53cc6f80f4e2b8a81
URL:         https://git.haiku-os.org/haiku/commit/?id=1cef8ebf6ec3
Author:      Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date:        Tue Jun  7 18:41:15 2022 UTC

----------------------------------------------------------------------------

1 file changed, 1 insertion(+), 1 deletion(-)
src/libs/compat/freebsd_network/callout.cpp | 2 +-

----------------------------------------------------------------------------

diff --git a/src/libs/compat/freebsd_network/callout.cpp 
b/src/libs/compat/freebsd_network/callout.cpp
index 009366b5ba..e91416c846 100644
--- a/src/libs/compat/freebsd_network/callout.cpp
+++ b/src/libs/compat/freebsd_network/callout.cpp
@@ -186,7 +186,7 @@ callout_reset(struct callout *c, int _ticks, void 
(*func)(void *), void *arg)
 
        TRACE("callout_reset %p, func %p, arg %p\n", c, c->c_func, c->c_arg);
 
-       if (ticks >= 0) {
+       if (_ticks >= 0) {
                // reschedule or add this timer
                if (c->due <= 0)
                        list_add_item(&sTimers, c);


Other related posts:

  • » [haiku-commits] haiku: hrev56162 - src/libs/compat/freebsd_network - waddlesplash