[haiku-commits] haiku: hrev54932 - src/system/boot/platform/efi

  • From: Alex von Gluck IV <kallisti5@xxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 29 Jan 2021 14:04:04 +0000 (UTC)

hrev54932 adds 1 changeset to branch 'master'
old head: 6f3a5c9ab0c2f388ef0ff6efff713732a710cd93
new head: 8c9dc662ee6b7fbf660534952b81aa9b77e27099
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=8c9dc662ee6b+%5E6f3a5c9ab0c2

----------------------------------------------------------------------------

8c9dc662ee6b: boot/platform/efi: Don't 'enable' graphics mode; solves #16753
  
  * Console-control is non-standard, but is needed on older Apple
    hardware to transition their EFI bioses to text-mode so our
    bootloader menu can be used / seen.
  * Console-control seems to exist on some older Intel hardware as
    well. Enabling it breaks our keyboard support. (maybe when enabled
    a different legacy UEFI call needs used to input or something)
  * Instead of trying to use a deprecated EFI call in a meaningful
    way, just do the "bare minimum" of disabling it when it exists.
  
  Change-Id: I20c3e026e02996371f632361c6899532c195bbf8
  Reviewed-on: https://review.haiku-os.org/c/haiku/+/3685
  Reviewed-by: Adrien Destugues <pulkomandy@xxxxxxxxx>

                          [ Alexander von Gluck IV <kallisti5@xxxxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev54932
Commit:      8c9dc662ee6b7fbf660534952b81aa9b77e27099
URL:         https://git.haiku-os.org/haiku/commit/?id=8c9dc662ee6b
Author:      Alexander von Gluck IV <kallisti5@xxxxxxxxxxx>
Date:        Fri Jan 29 00:56:29 2021 UTC
Committer:   Alex von Gluck IV <kallisti5@xxxxxxxxxxx>
Commit-Date: Fri Jan 29 14:03:55 2021 UTC

Ticket:      https://dev.haiku-os.org/ticket/16753

----------------------------------------------------------------------------

1 file changed, 4 insertions(+), 1 deletion(-)
src/system/boot/platform/efi/console.cpp | 5 ++++-

----------------------------------------------------------------------------

diff --git a/src/system/boot/platform/efi/console.cpp 
b/src/system/boot/platform/efi/console.cpp
index 5747436632..f83428b534 100644
--- a/src/system/boot/platform/efi/console.cpp
+++ b/src/system/boot/platform/efi/console.cpp
@@ -249,7 +249,10 @@ console_control(bool graphics)
 status_t
 console_init(void)
 {
-       console_control(true);
+       // Solves video issues on Apple hardware. This is non-standard and
+       // deprecated and should not be used for anything else!
+       console_control(false);
+
        update_screen_size();
        console_hide_cursor();
        console_clear_screen();


Other related posts:

  • » [haiku-commits] haiku: hrev54932 - src/system/boot/platform/efi - Alex von Gluck IV