hrev54784 adds 1 changeset to branch 'master'
old head: 5b1ae51c6bb2a69e94d3a8a0a3ef96ed627256d9
new head: b66b01c28337d381d8f96c5354b0f88d79a15504
overview:
https://git.haiku-os.org/haiku/log/?qt=range&q=b66b01c28337+%5E5b1ae51c6bb2
----------------------------------------------------------------------------
b66b01c28337: bin/bfs_tools: Fix array index is out of bounds
If length == BPLUSTREE_MAX_KEY_LENGTH at line 237,
buffer[] index may be out of bounds at line 245.
Pointed out by cppcheck.
Change-Id: Ib86abeaa72526b327af85ca9a26b050834f5a2c9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3501
Reviewed-by: Jérôme Duval <jerome.duval@xxxxxxxxx>
[ Murai Takashi <tmurai01@xxxxxxxxx> ]
----------------------------------------------------------------------------
Revision: hrev54784
Commit: b66b01c28337d381d8f96c5354b0f88d79a15504
URL: https://git.haiku-os.org/haiku/commit/?id=b66b01c28337
Author: Murai Takashi <tmurai01@xxxxxxxxx>
Date: Sun Dec 13 10:46:00 2020 UTC
Committer: Jérôme Duval <jerome.duval@xxxxxxxxx>
Commit-Date: Sun Dec 13 16:44:30 2020 UTC
----------------------------------------------------------------------------
1 file changed, 1 insertion(+), 1 deletion(-)
src/bin/bfs_tools/lib/dump.cpp | 2 +-
----------------------------------------------------------------------------
diff --git a/src/bin/bfs_tools/lib/dump.cpp b/src/bin/bfs_tools/lib/dump.cpp
index 523e50cd5c..178e9f44b6 100644
--- a/src/bin/bfs_tools/lib/dump.cpp
+++ b/src/bin/bfs_tools/lib/dump.cpp
@@ -240,7 +240,7 @@ dump_bplustree_node(const bplustree_node* node, const
bplustree_header* header,
break;
}
- char buffer[256];
+ char buffer[BPLUSTREE_MAX_KEY_LENGTH + 1];
memcpy(buffer, key, length);
buffer[length] = '\0';
