[haiku-commits] haiku: hrev53475 - src/apps/deskbar

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 12 Sep 2019 05:38:45 -0400 (EDT)

hrev53475 adds 1 changeset to branch 'master'
old head: 0fe6734183ab7727b19c1f247382a75190787d0e
new head: 9a9f4ef578de57d2abe476fe6326341b3d290818
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=9a9f4ef578de+%5E0fe6734183ab

----------------------------------------------------------------------------

9a9f4ef578de: Deskbar: Made expander knobs light when menu background is dark
  
  Change-Id: I56a2fe1d4b1ce66476077e96e64066bf2950b4b4
  Reviewed-on: https://review.haiku-os.org/c/haiku/+/1846
  Reviewed-by: Stephan Aßmus <superstippi@xxxxxx>

                       [ Mikael Konradsson <mikael.konradsson@xxxxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev53475
Commit:      9a9f4ef578de57d2abe476fe6326341b3d290818
URL:         https://git.haiku-os.org/haiku/commit/?id=9a9f4ef578de
Author:      Mikael Konradsson <mikael.konradsson@xxxxxxxxxxx>
Date:        Sat Sep  7 11:32:22 2019 UTC
Committer:   Stephan Aßmus <superstippi@xxxxxx>
Commit-Date: Thu Sep 12 09:38:41 2019 UTC

----------------------------------------------------------------------------

1 file changed, 10 insertions(+), 2 deletions(-)
src/apps/deskbar/TeamMenuItem.cpp | 12 ++++++++++--

----------------------------------------------------------------------------

diff --git a/src/apps/deskbar/TeamMenuItem.cpp 
b/src/apps/deskbar/TeamMenuItem.cpp
index 6fb53218a3..6fcecd8a56 100644
--- a/src/apps/deskbar/TeamMenuItem.cpp
+++ b/src/apps/deskbar/TeamMenuItem.cpp
@@ -308,9 +308,17 @@ TTeamMenuItem::DrawExpanderArrow()
 
        rect.OffsetTo(BPoint(frame.right - rect.Width(),
                ContentLocation().y + ((frame.Height() - rect.Height()) / 2)));
+
+       float colorTint = B_DARKEN_3_TINT;
+
+       rgb_color bgColor = ui_color(B_MENU_BACKGROUND_COLOR);
+       if (bgColor.red + bgColor.green + bgColor.blue <= 128 * 3) {
+               colorTint = B_LIGHTEN_2_TINT;
+       }
+
        be_control_look->DrawArrowShape(menu, rect, rect,
-               ui_color(B_MENU_BACKGROUND_COLOR), fArrowDirection, 0,
-               B_DARKEN_3_TINT);
+               bgColor, fArrowDirection, 0,
+               colorTint);
 }
 
 


Other related posts:

  • » [haiku-commits] haiku: hrev53475 - src/apps/deskbar - Stephan Aßmus