[haiku-commits] Re: haiku: hrev53471 - in src/system/kernel: disk_device_manager fs

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 10 Sep 2019 09:11:15 +0200

Am 10/09/2019 um 02:52 schrieb waddlesplash:

        status = manager->InitialDeviceScan();
        if (status != B_OK) {
-               dprintf("KDiskDeviceManager::InitialDeviceScan() failed: %s\n",
+               dprintf("KDiskDeviceManager::InitialDeviceScan() returned error: 
%s\n",
                        strerror(status));
-               return status;
+               // InitialDeviceScan returns error if one (or more) partitions 
are
+               // determined to be invalid. The partition we are trying to 
boot from
+               // may be usuable anyway, so don't fail here.

Wouldn't it be nicer if InitialDeviceScan() logs errors itself, and only returns an error when it actually couldn't do anything useful?

Bye,
   Axel.

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 09-2019