[haiku-commits] haiku: hrev53306 - headers/libs/agg

  • From: Jérôme Duval <jerome.duval@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 28 Jul 2019 06:16:47 -0400 (EDT)

hrev53306 adds 1 changeset to branch 'master'
old head: fd97a8c7fe51576b851bc00ea6a49b76d4434dcf
new head: b0890e034b12037d06e9d310c1f15f0f06da2513
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=b0890e034b12+%5Efd97a8c7fe51

----------------------------------------------------------------------------

b0890e034b12: PVS V501: comparing number with itself
  
  I assume the intent was the same as in other similar functions above.
  
  Change-Id: I887cd73d846680a5a5ec5c90f678ad4b12122eb3
  Reviewed-on: https://review.haiku-os.org/c/1655
  Reviewed-by: Jérôme Duval <jerome.duval@xxxxxxxxx>

                             [ Adrien Destugues <pulkomandy@xxxxxxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev53306
Commit:      b0890e034b12037d06e9d310c1f15f0f06da2513
URL:         https://git.haiku-os.org/haiku/commit/?id=b0890e034b12
Author:      Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
Date:        Sun Jul 28 09:03:24 2019 UTC
Committer:   Jérôme Duval <jerome.duval@xxxxxxxxx>
Commit-Date: Sun Jul 28 10:16:43 2019 UTC

----------------------------------------------------------------------------

1 file changed, 3 insertions(+), 3 deletions(-)
headers/libs/agg/agg_span_image_filter_rgba.h | 6 +++---

----------------------------------------------------------------------------

diff --git a/headers/libs/agg/agg_span_image_filter_rgba.h 
b/headers/libs/agg/agg_span_image_filter_rgba.h
index d47085cf6c..440b0f3d9f 100644
--- a/headers/libs/agg/agg_span_image_filter_rgba.h
+++ b/headers/libs/agg/agg_span_image_filter_rgba.h
@@ -895,9 +895,9 @@ namespace agg
                 if(fg[3] < 0) fg[3] = 0;
 
                 if(fg[order_type::A] > base_mask)         fg[order_type::A] = 
base_mask;
-                if(fg[order_type::R] > fg[order_type::R]) fg[order_type::R] = 
fg[order_type::R];
-                if(fg[order_type::G] > fg[order_type::G]) fg[order_type::G] = 
fg[order_type::G];
-                if(fg[order_type::B] > fg[order_type::B]) fg[order_type::B] = 
fg[order_type::B];
+                if(fg[order_type::R] > fg[order_type::A]) fg[order_type::R] = 
fg[order_type::A];
+                if(fg[order_type::G] > fg[order_type::A]) fg[order_type::G] = 
fg[order_type::A];
+                if(fg[order_type::B] > fg[order_type::A]) fg[order_type::B] = 
fg[order_type::A];
 
                 span->r = (value_type)fg[order_type::R];
                 span->g = (value_type)fg[order_type::G];


Other related posts:

  • » [haiku-commits] haiku: hrev53306 - headers/libs/agg - Jérôme Duval