[haiku-commits] Re: haiku: hrev53082 - src/system/boot/loader

  • From: Jessica Hamilton <jessica.l.hamilton@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 24 Apr 2019 03:10:26 +1200

On Wed, 24 Apr 2019 at 03:06, Jessica Hamilton
<jessica.l.hamilton@xxxxxxxxx> wrote:


On Wed, 24 Apr 2019 at 00:48, Adrien Destugues <pulkomandy@xxxxxxxxxxxxx> 
wrote:

Could you please use Gerrit more? That's exactly what it is made for.

well...

https://review.haiku-os.org/c/haiku/+/1406

But still, it looks like we do need two people reviewing (one giving +2 and 
one clicking merge).
There is no hurry to get everything merged.

I didn't make any of those changes, my patch was
https://review.haiku-os.org/c/haiku/+/1406/2. I don't know how all
that other stuff got added to the commit in patchset 3 using
git-review command. I downloaded the patchset, removed one comment,
uploaded it, and all those other changes somehow ended up in there,
which it seems nobody noticed; I certainly didn't, and I'm pretty sure
I did look :/

Ohh, I was experimenting with clang-format, but I'm sure I hadn't done
that then :/ Anyway, I'll fix it all up.

Other related posts: