[haiku-commits] haiku: hrev52913 - build/scripts headers/os/interface build/jam

  • From: waddlesplash <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 21 Feb 2019 16:13:51 -0500 (EST)

hrev52913 adds 4 changesets to branch 'master'
old head: 83a69e16c5a72b183574ea508dc5435da60fe79d
new head: 2fc0c841121dd576b867a386aa19ce486d409fa1
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=2fc0c841121d+%5E83a69e16c5a7

----------------------------------------------------------------------------

5a7156f43527: build_cross_tools_gcc4: Clear "missing" scripts instead of 
touching files.
  
  This just stops the errors from occuring rather than trying to
  rebuild the files at all. This is much cleaner, and solves
  a few cases that the other method did not.

4dd5af2f7547: build_cross_tools_gcc4: Handle $PATH having spaces in it properly.
  
  Fixes the build of the cross tools under WSL.

86dfe1d9a828: BAffineTransform: Remove "register" storage class.
  
  Long since deprecated, and compilers can figure this out on
  their own now. Fixes a lot of errors in Clang.

2fc0c841121d: ArchitectureRules: Add -Wno-builtin-requires-header to Clang 
flags.
  
  It warns when you try to use some standard library functions
  without including the system headers, which we don't
  care about as we are providing the system headers in the tree.

                              [ Augustin Cavalier <waddlesplash@xxxxxxxxx> ]

----------------------------------------------------------------------------

3 files changed, 15 insertions(+), 22 deletions(-)
build/jam/ArchitectureRules            |  6 ++++--
build/scripts/build_cross_tools_gcc4   | 23 +++++++----------------
headers/os/interface/AffineTransform.h |  8 ++++----

############################################################################

Commit:      5a7156f4352715268eec645cb4c64c25884c64b1
URL:         https://git.haiku-os.org/haiku/commit/?id=5a7156f43527
Author:      Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date:        Thu Feb 21 19:01:40 2019 UTC

build_cross_tools_gcc4: Clear "missing" scripts instead of touching files.

This just stops the errors from occuring rather than trying to
rebuild the files at all. This is much cleaner, and solves
a few cases that the other method did not.

----------------------------------------------------------------------------

diff --git a/build/scripts/build_cross_tools_gcc4 
b/build/scripts/build_cross_tools_gcc4
index 674c05ca3e..da11e14017 100755
--- a/build/scripts/build_cross_tools_gcc4
+++ b/build/scripts/build_cross_tools_gcc4
@@ -135,21 +135,12 @@ if [ -z "$gccVersion" ]; then
        exit 1
 fi
 
-# touch all info files in order to avoid the dependency on makeinfo
-# (which apparently doesn't work reliably on all the different host
-# configurations and changes files which in turn appear as local changes
-# to the VCS).
-find "$binutilsSourceDir" "$gccSourceDir" -name \*.info -print0 | xargs -0 
touch
-
-# touch all configure files in order to avoid them being auto-rebuilt,
-# as this often fails because the host system does not have the exact
-# version of autofools that GCC wants
-find "$binutilsSourceDir" "$gccSourceDir" \( -name configure -o -name \*.in \) 
-print0 | xargs -0 touch
-
-# export some variables to stop the subsequent configure/make from invoking
-# tools which we don't require the user to have installed (or do not require
-# a specific version of, which autofools does.)
-export ACLOCAL=:
+# clear out the "missing" scripts so that they don't cause errors on tools
+# that are not installed, as we will have committed any files generated by
+# them to the buildtools repo already.
+echo "#!/bin/sh" >"$binutilsSourceDir"/missing
+echo "#!/bin/sh" >"$gccSourceDir"/missing
+echo "#!/bin/sh" >"$gccSourceDir"/isl/missing
 
 # create the object and installation directories for the cross compilation 
tools
 objDir="${installDir}-build"

############################################################################

Commit:      4dd5af2f7547fb07fc00e0addfe044365902762b
URL:         https://git.haiku-os.org/haiku/commit/?id=4dd5af2f7547
Author:      Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date:        Thu Feb 21 19:02:13 2019 UTC

build_cross_tools_gcc4: Handle $PATH having spaces in it properly.

Fixes the build of the cross tools under WSL.

----------------------------------------------------------------------------

diff --git a/build/scripts/build_cross_tools_gcc4 
b/build/scripts/build_cross_tools_gcc4
index da11e14017..92a97fa743 100755
--- a/build/scripts/build_cross_tools_gcc4
+++ b/build/scripts/build_cross_tools_gcc4
@@ -209,7 +209,7 @@ CFLAGS="$ccFlags" CXXFLAGS="$cxxFlags" 
"$binutilsSourceDir/configure" \
 $MAKE $additionalMakeArgs || exit 1
 $MAKE $additionalMakeArgs install || exit 1
 
-export PATH=$PATH:"$installDir/bin"
+export PATH="$PATH:$installDir/bin"
 
 if [ "$HAIKU_USE_GCC_GRAPHITE" = 1 ]; then
        # build gmp

############################################################################

Commit:      86dfe1d9a8288af1942fd55c164de89221ef3a33
URL:         https://git.haiku-os.org/haiku/commit/?id=86dfe1d9a828
Author:      Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date:        Thu Feb 21 19:03:05 2019 UTC

BAffineTransform: Remove "register" storage class.

Long since deprecated, and compilers can figure this out on
their own now. Fixes a lot of errors in Clang.

----------------------------------------------------------------------------

diff --git a/headers/os/interface/AffineTransform.h 
b/headers/os/interface/AffineTransform.h
index c296c00c50..da1efbda98 100644
--- a/headers/os/interface/AffineTransform.h
+++ b/headers/os/interface/AffineTransform.h
@@ -221,7 +221,7 @@ extern const BAffineTransform B_AFFINE_IDENTITY_TRANSFORM;
 inline void
 BAffineTransform::Apply(double* x, double* y) const
 {
-       register double tmp = *x;
+       double tmp = *x;
        *x = tmp * sx + *y * shx + tx;
        *y = tmp * shy + *y * sy + ty;
 }
@@ -230,9 +230,9 @@ BAffineTransform::Apply(double* x, double* y) const
 inline void
 BAffineTransform::ApplyInverse(double* x, double* y) const
 {
-       register double d = InverseDeterminant();
-       register double a = (*x - tx) * d;
-       register double b = (*y - ty) * d;
+       double d = InverseDeterminant();
+       double a = (*x - tx) * d;
+       double b = (*y - ty) * d;
        *x = a * sy - b * shx;
        *y = b * sx - a * shy;
 }

############################################################################

Revision:    hrev52913
Commit:      2fc0c841121dd576b867a386aa19ce486d409fa1
URL:         https://git.haiku-os.org/haiku/commit/?id=2fc0c841121d
Author:      Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date:        Thu Feb 21 19:04:05 2019 UTC

ArchitectureRules: Add -Wno-builtin-requires-header to Clang flags.

It warns when you try to use some standard library functions
without including the system headers, which we don't
care about as we are providing the system headers in the tree.

----------------------------------------------------------------------------

diff --git a/build/jam/ArchitectureRules b/build/jam/ArchitectureRules
index 7968ac9be2..54809c2d8c 100644
--- a/build/jam/ArchitectureRules
+++ b/build/jam/ArchitectureRules
@@ -125,9 +125,11 @@ rule ArchitectureSetup architecture
        # disable some Clang warnings that are not very useful
        if $(HAIKU_CC_IS_CLANG_$(architecture)) = 1 {
                HAIKU_WARNING_CCFLAGS_$(architecture) += 
-Wno-address-of-packed-member
-                       -Wno-unused-private-field -Wno-cast-align 
-Wno-gnu-designator ;
+                       -Wno-unused-private-field -Wno-cast-align 
-Wno-gnu-designator
+                       -Wno-builtin-requires-header ;
                HAIKU_WARNING_C++FLAGS_$(architecture) += 
-Wno-address-of-packed-member
-                       -Wno-unused-private-field -Wno-cast-align 
-Wno-gnu-designator ;
+                       -Wno-unused-private-field -Wno-cast-align 
-Wno-gnu-designator
+                       -Wno-builtin-requires-header ;
        }
 
        HAIKU_WERROR_FLAGS_$(architecture) = ;


Other related posts:

  • » [haiku-commits] haiku: hrev52913 - build/scripts headers/os/interface build/jam - waddlesplash