[haiku-commits] haiku: hrev52856 - in src: kits/tracker apps/charactermap

  • From: waddlesplash <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 11 Feb 2019 16:12:38 -0500 (EST)

hrev52856 adds 2 changesets to branch 'master'
old head: f37553039bf1bb94359baf44c5121f11ada24f85
new head: 35758c70466ac6a2d581101a09c9e9ddc7f003f6
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=35758c70466a+%5Ef37553039bf1

----------------------------------------------------------------------------

514aaae7b153: Tracker: Remove list view menu from virtual directory window.
  
  This reverts commit ed99a95f359befa9029c95f173b025ad2d1af1b9.
  
  It isn't needed now that list view sizing is dependent
  on system font size.
  
  Fixes #14897.

35758c70466a: CharacterMap: The CharacterView is scroll-view aware.
  
  Fixes #14897.

                              [ Augustin Cavalier <waddlesplash@xxxxxxxxx> ]

----------------------------------------------------------------------------

2 files changed, 2 insertions(+), 27 deletions(-)
src/apps/charactermap/CharacterView.cpp     |  3 ++-
src/kits/tracker/VirtualDirectoryWindow.cpp | 26 -------------------------

############################################################################

Commit:      514aaae7b1537ed5bcca8e4f5cad3a9290219bc8
URL:         https://git.haiku-os.org/haiku/commit/?id=514aaae7b153
Author:      Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date:        Mon Feb 11 21:06:49 2019 UTC

Ticket:      https://dev.haiku-os.org/ticket/14897

Tracker: Remove list view menu from virtual directory window.

This reverts commit ed99a95f359befa9029c95f173b025ad2d1af1b9.

It isn't needed now that list view sizing is dependent
on system font size.

Fixes #14897.

----------------------------------------------------------------------------

diff --git a/src/kits/tracker/VirtualDirectoryWindow.cpp 
b/src/kits/tracker/VirtualDirectoryWindow.cpp
index b28dc4f814..40e361bfd8 100644
--- a/src/kits/tracker/VirtualDirectoryWindow.cpp
+++ b/src/kits/tracker/VirtualDirectoryWindow.cpp
@@ -134,32 +134,6 @@ void
 VirtualDirectoryWindow::AddWindowMenu(BMenu* menu)
 {
        BMenuItem* item;
-       BMessage* message;
-
-       BMenu* listViewMenu = new BMenu(B_TRANSLATE("List view"));
-
-       message = new BMessage(kListMode);
-       message->AddInt32("icon_size", B_MINI_ICON);
-       item = new BMenuItem(listViewMenu, message);
-       item->SetShortcut('3', B_COMMAND_KEY);
-       item->SetTarget(PoseView());
-       menu->AddItem(item);
-
-       message = new BMessage(kListMode);
-       message->AddInt32("icon_size", B_MINI_ICON);
-       item = new BMenuItem(B_TRANSLATE("Mini"), message);
-       item->SetTarget(PoseView());
-       listViewMenu->AddItem(item);
-
-       message = new BMessage(kListMode);
-       message->AddInt32("icon_size", B_LARGE_ICON);
-       item = new BMenuItem(B_TRANSLATE("Large"), message);
-       item->SetTarget(PoseView());
-       listViewMenu->AddItem(item);
-
-       listViewMenu->SetTargetForItems(PoseView());
-
-       menu->AddSeparatorItem();
 
        item = new BMenuItem(B_TRANSLATE("Resize to fit"),
                new BMessage(kResizeToFit), 'Y');

############################################################################

Revision:    hrev52856
Commit:      35758c70466ac6a2d581101a09c9e9ddc7f003f6
URL:         https://git.haiku-os.org/haiku/commit/?id=35758c70466a
Author:      Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date:        Mon Feb 11 21:11:18 2019 UTC

Ticket:      https://dev.haiku-os.org/ticket/14897

CharacterMap: The CharacterView is scroll-view aware.

Fixes #14897.

----------------------------------------------------------------------------

diff --git a/src/apps/charactermap/CharacterView.cpp 
b/src/apps/charactermap/CharacterView.cpp
index e4f41db420..694fd0f3b9 100644
--- a/src/apps/charactermap/CharacterView.cpp
+++ b/src/apps/charactermap/CharacterView.cpp
@@ -27,7 +27,8 @@ static const uint32 kMsgCopyAsEscapedString = 'cesc';
 
 
 CharacterView::CharacterView(const char* name)
-       : BView(name, B_WILL_DRAW | B_FULL_UPDATE_ON_RESIZE | B_FRAME_EVENTS),
+       : BView(name, B_WILL_DRAW | B_FULL_UPDATE_ON_RESIZE | B_FRAME_EVENTS
+               | B_SCROLL_VIEW_AWARE),
        fTargetCommand(0),
        fClickPoint(-1, 0),
        fHasCharacter(false),


Other related posts:

  • » [haiku-commits] haiku: hrev52856 - in src: kits/tracker apps/charactermap - waddlesplash