[haiku-commits] haiku: hrev52498 - src/add-ons/mail_daemon/outbound_protocols/smtp

  • From: waddlesplash@xxxxxxxxxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 4 Nov 2018 13:57:30 -0500 (EST)

hrev52498 adds 1 changeset to branch 'master'
old head: b5ecd7c203525310fe5aad1400ea1dde8665ffe6
new head: 1ad1c1c87b637da6f7892cd16a0a0f0b3b4d15e8
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=1ad1c1c87b63+%5Eb5ecd7c20352

----------------------------------------------------------------------------

1ad1c1c87b63: mail_daemon: ESMTP auth fix (250 AUTH reply)
  
  See RFC 5231 (https://tools.ietf.org/html/rfc5321): "Following the normal
  syntax for multiline replies, these keywords follow the code (250) and a
  hyphen for all but the last line..."
  
  Change-Id: I1ee533a332d1e18ffddd4ad1520d14f4013b739e
  Reviewed-on: https://review.haiku-os.org/670
  Reviewed-by: waddlesplash <waddlesplash@xxxxxxxxx>

                                         [ Peter Kosyh <p.kosyh@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev52498
Commit:      1ad1c1c87b637da6f7892cd16a0a0f0b3b4d15e8
URL:         https://git.haiku-os.org/haiku/commit/?id=1ad1c1c87b63
Author:      Peter Kosyh <p.kosyh@xxxxxxxxx>
Date:        Sun Nov  4 18:45:10 2018 UTC
Committer:   waddlesplash <waddlesplash@xxxxxxxxx>
Commit-Date: Sun Nov  4 18:57:28 2018 UTC

----------------------------------------------------------------------------

1 file changed, 2 insertions(+), 1 deletion(-)
src/add-ons/mail_daemon/outbound_protocols/smtp/SMTP.cpp | 3 ++-

----------------------------------------------------------------------------

diff --git a/src/add-ons/mail_daemon/outbound_protocols/smtp/SMTP.cpp 
b/src/add-ons/mail_daemon/outbound_protocols/smtp/SMTP.cpp
index 81436313cc..43a29548f5 100644
--- a/src/add-ons/mail_daemon/outbound_protocols/smtp/SMTP.cpp
+++ b/src/add-ons/mail_daemon/outbound_protocols/smtp/SMTP.cpp
@@ -425,7 +425,8 @@ SMTPProtocol::Open(const char *address, int port, bool 
esmtp)
        if (esmtp) {
                const char *res = fLog.String();
                char *p;
-               if ((p = ::strstr(res, "250-AUTH")) != NULL) {
+               if ((p = ::strstr(res, "250-AUTH")) != NULL
+                               || (p = ::strstr(res, "250 AUTH")) != NULL) {
                        if(::strstr(p, "LOGIN"))
                                fAuthType |= LOGIN;
                        if(::strstr(p, "PLAIN"))


Other related posts:

  • » [haiku-commits] haiku: hrev52498 - src/add-ons/mail_daemon/outbound_protocols/smtp - waddlesplash