[haiku-commits] Re: haiku: hrev52487 - src/add-ons/mail_daemon/inbound_protocols/imap
- From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 6 Nov 2018 08:43:40 +0100
Am 03/11/2018 um 19:46 schrieb waddlesplash@xxxxxxxxxxxxxxxx:
ed08b22decaf: add-ons/mail_daemon: IMAP: limit UIDs in UID FETCH
Some IMAP servers (such as dovecot) have hard line length limits for
commands.
The way UID FETCH was being scheduled was creating FETCHes longer than
the maximum length.
I wasn't too fond of that solution as I wrote in Gerrit. You only
changed the style issues, not the code issues.
Looking at the implementation of IMAP::FetchCommand, it looks like this
change is completely superfluous: it already limits the message length
-- maybe it's just too large (it's 2048 bytes), or the implementation buggy.
In any case, this one should be reverted.
Bye,
Axel.
Other related posts:
