hrev52312 adds 1 changeset to branch 'master'
old head: 3cc5e76f2d754d213cb896d1cc0dea5d43854b13
new head: 09095817eb0340fe0165accc44a84877fb4b88aa
overview:
https://git.haiku-os.org/haiku/log/?qt=range&q=09095817eb03+%5E3cc5e76f2d75
----------------------------------------------------------------------------
09095817eb03: Mediaplayer: Suppress -Werror=class-memaccess
Suppress -Werror=class-memaccess pointed out by gcc8.
* Remove unneed memset(), since media_format is cleared by constructor.
* Use media_format::Clear() instead of memset()
Change-Id: I02e19c1fab1f1b3f6c348e1d3ac63536d5c829b2
Reviewed-on: https://review.haiku-os.org/484
Reviewed-by: Barrett17 <b.vitruvio@xxxxxxxxx>
[ Murai Takashi <tmurai01@xxxxxxxxx> ]
----------------------------------------------------------------------------
Revision: hrev52312
Commit: 09095817eb0340fe0165accc44a84877fb4b88aa
URL: https://git.haiku-os.org/haiku/commit/?id=09095817eb03
Author: Murai Takashi <tmurai01@xxxxxxxxx>
Date: Fri May 18 23:58:10 2018 UTC
Committer: Barrett17 <b.vitruvio@xxxxxxxxx>
Commit-Date: Wed Sep 5 09:29:01 2018 UTC
----------------------------------------------------------------------------
2 files changed, 2 insertions(+), 3 deletions(-)
src/apps/mediaplayer/media_node_framework/NodeManager.cpp | 1 -
src/apps/mediaplayer/supplier/MediaTrackVideoSupplier.cpp | 4 ++--
----------------------------------------------------------------------------
diff --git a/src/apps/mediaplayer/media_node_framework/NodeManager.cpp
b/src/apps/mediaplayer/media_node_framework/NodeManager.cpp
index e984a57d0c..a1d9ff466e 100644
--- a/src/apps/mediaplayer/media_node_framework/NodeManager.cpp
+++ b/src/apps/mediaplayer/media_node_framework/NodeManager.cpp
@@ -41,7 +41,6 @@ NodeManager::Connection::Connection()
:
connected(false)
{
- memset(&format, 0, sizeof(media_format));
}
diff --git a/src/apps/mediaplayer/supplier/MediaTrackVideoSupplier.cpp
b/src/apps/mediaplayer/supplier/MediaTrackVideoSupplier.cpp
index e83c09e0c2..4a29617244 100644
--- a/src/apps/mediaplayer/supplier/MediaTrackVideoSupplier.cpp
+++ b/src/apps/mediaplayer/supplier/MediaTrackVideoSupplier.cpp
@@ -268,7 +268,7 @@ status_t
MediaTrackVideoSupplier::_SwitchFormat(color_space format, uint32 bytesPerRow)
{
// get the encoded format
- memset(&fFormat, 0, sizeof(media_format));
+ fFormat.Clear();
status_t ret = fVideoTrack->EncodedFormat(&fFormat);
if (ret < B_OK) {
printf("MediaTrackVideoSupplier::_SwitchFormat() - "
@@ -349,7 +349,7 @@ MediaTrackVideoSupplier::_SetDecodedFormat(uint32 width,
uint32 height,
{
// specifiy the decoded format. we derive this information from
// the encoded format (width & height).
- memset(&fFormat, 0, sizeof(media_format));
+ fFormat.Clear();
// fFormat.u.raw_video.last_active = height - 1;
// fFormat.u.raw_video.orientation = B_VIDEO_TOP_LEFT_RIGHT;
// fFormat.u.raw_video.pixel_width_aspect = 1;
