[haiku-commits] haiku: hrev52203 - src/kits/network/libnetapi

  • From: waddlesplash <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 9 Aug 2018 20:17:10 -0400 (EDT)

hrev52203 adds 1 changeset to branch 'master'
old head: b8761dc31c49e5bb36e6ca430863476f815763c8
new head: 00cbe4cccad1b5ecd00588f98266b219d8770fb9
overview: 
https://git.haiku-os.org/haiku/log/?qt=range&q=00cbe4cccad1+%5Eb8761dc31c49

----------------------------------------------------------------------------

00cbe4cccad1: Replace strncpy with strlcpy
  
  Since destination size equals number of characters to copy.
  Pointed out by gcc8. [-Werror=stringop-truncation]
  
  Change-Id: I8f2118129ec2324bb1f93857f5abfdf121c864f0
  Reviewed-on: https://review.haiku-os.org/450
  Reviewed-by: Adrien Destugues <pulkomandy@xxxxxxxxx>
  Reviewed-by: Skipp_OSX <jscipione@xxxxxxxxx>

                                      [ Murai Takashi <tmurai01@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev52203
Commit:      00cbe4cccad1b5ecd00588f98266b219d8770fb9
URL:         https://git.haiku-os.org/haiku/commit/?id=00cbe4cccad1
Author:      Murai Takashi <tmurai01@xxxxxxxxx>
Date:        Wed Aug  8 11:02:04 2018 UTC
Committer:   waddlesplash <waddlesplash@xxxxxxxxx>
Commit-Date: Fri Aug 10 00:17:07 2018 UTC

----------------------------------------------------------------------------

1 file changed, 1 insertion(+), 1 deletion(-)
src/kits/network/libnetapi/NetworkRoster.cpp | 2 +-

----------------------------------------------------------------------------

diff --git a/src/kits/network/libnetapi/NetworkRoster.cpp 
b/src/kits/network/libnetapi/NetworkRoster.cpp
index 3171aaffaf..8f840b5d28 100644
--- a/src/kits/network/libnetapi/NetworkRoster.cpp
+++ b/src/kits/network/libnetapi/NetworkRoster.cpp
@@ -207,7 +207,7 @@ BNetworkRoster::GetNextPersistentNetwork(uint32* cookie,
                return B_ERROR;
 
        memset(network.name, 0, sizeof(network.name));
-       strncpy(network.name, networkName.String(), sizeof(network.name));
+       strlcpy(network.name, networkName.String(), sizeof(network.name));
 
        BNetworkAddress address;
        if (networkMessage.FindFlat("address", &network.address) != B_OK)


Other related posts: