[haiku-commits] Re: haiku: hrev52152 - src/system/boot/platform/efi src/system/boot/platform/generic headers/private/kernel/boot/platform/generic src/system/boot/platform/u-boot src/system/boot/platform/amiga_m68k

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 2 Aug 2018 10:28:08 +0200

Am 01/08/2018 um 21:12 schrieb Fredrik Holmqvist:

15db6949b6e2: Don't clear video mem on UEFI, efi video mode refactor

Just pointing out a few coding style issues:

+++ b/src/system/boot/platform/efi/video.cpp
@@ -129,17 +127,16 @@ get_mode_from_settings(void)
[...]
+               if (parameter.value_count < 3 || strcmp(parameter.name, "mode") 
!= 0) continue;

"continue;" goes to the next line.

+++ b/src/system/boot/platform/generic/video_splash.cpp
@@ -81,14 +81,14 @@ uncompress(const uint8 compressed[], unsigned int 
compressedSize,
[...]
-       // clear the video memory
-       memset((void*)frameBuffer, 0,
-               gKernelArgs.frame_buffer.physical_buffer.size);
+       if (clear)
+               memset((void*)frameBuffer, 0,
+                       gKernelArgs.frame_buffer.physical_buffer.size);

Please use blocks around multi-line statements (even if it's only a single statement that needs more than one line).

Bye,
   Axel.

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 08-2018