hrev52140 adds 3 changesets to branch 'master'
old head: 55557aa1626a8030f7d88a0ab9746e4a9c09d454
new head: 5ad9670f398319f7f48929721ad2b77da737f7d1
overview:
https://git.haiku-os.org/haiku/log/?qt=range&q=5ad9670f3983+%5E55557aa1626a
----------------------------------------------------------------------------
c67634d98c9a: BuildSetup: __NO_INLINE__ and -fno-delete-null-pointer-checks.
* __NO_INLINE__ fixes the cross-build on some glibc-based systems with
newer compilers, as it prevents glibc from declaring functions inline
that we override in libroot_build.
* We can now enable tree-vrp as long as no-delete-null-pointer-checks
goes where it used to.
1587c3c55592: ArchitectureRules: Enable no-delete-null-pointer-checks on Clang.
This requires a trunk build of Clang (the flag was only implemented
& introduced 12 days ago), but at present, full builds will fail
due to an unrelated Clang bug: https://bugs.llvm.org/show_bug.cgi?id=38356
5ad9670f3983: intel_extreme, radeon_hd: Use bufferLength instead of
B_FILE_NAME_LENGTH.
Thanks korli for the review!
[ Augustin Cavalier <waddlesplash@xxxxxxxxx> ]
----------------------------------------------------------------------------
4 files changed, 7 insertions(+), 7 deletions(-)
build/jam/ArchitectureRules | 2 +-
build/jam/BuildSetup | 4 ++--
src/add-ons/kernel/drivers/graphics/intel_extreme/device.cpp | 4 ++--
src/add-ons/kernel/drivers/graphics/radeon_hd/device.cpp | 4 ++--
############################################################################
Commit: c67634d98c9aa02f0355f4b1d3997b847450bbf5
URL: https://git.haiku-os.org/haiku/commit/?id=c67634d98c9a
Author: Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date: Tue Jul 31 00:35:46 2018 UTC
BuildSetup: __NO_INLINE__ and -fno-delete-null-pointer-checks.
* __NO_INLINE__ fixes the cross-build on some glibc-based systems with
newer compilers, as it prevents glibc from declaring functions inline
that we override in libroot_build.
* We can now enable tree-vrp as long as no-delete-null-pointer-checks
goes where it used to.
----------------------------------------------------------------------------
diff --git a/build/jam/BuildSetup b/build/jam/BuildSetup
index 9f4104da8b..41b6398a01 100644
--- a/build/jam/BuildSetup
+++ b/build/jam/BuildSetup
@@ -300,7 +300,7 @@ if $(HOST_PLATFORM) != cygwin {
}
if $(HOST_GCC_VERSION[1]) >= 3 {
- HOST_GCC_BASE_FLAGS += -fno-strict-aliasing -fno-tree-vrp ;
+ HOST_GCC_BASE_FLAGS += -fno-strict-aliasing
-fno-delete-null-pointer-checks ;
}
HOST_KERNEL_CCFLAGS += $(HOST_GCC_BASE_FLAGS) -finline -fno-builtin
@@ -387,7 +387,7 @@ if $(HOST_PLATFORM_BEOS_COMPATIBLE) {
}
HOST_DEFINES += ARCH_$(HOST_CPU) ;
-HOST_DEFINES += _NO_INLINE_ASM ;
+HOST_DEFINES += _NO_INLINE_ASM __NO_INLINE__ ;
# for builds of tools in the current environment
HOST_BUILD_COMPATIBILITY_LIB_DIR = [ FDirName $(HOST_OBJECT_BASE_DIR) lib ] ;
############################################################################
Commit: 1587c3c55592d2e22d20f39b16cb3e6f4642bcaf
URL: https://git.haiku-os.org/haiku/commit/?id=1587c3c55592
Author: Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date: Tue Jul 31 00:37:27 2018 UTC
ArchitectureRules: Enable no-delete-null-pointer-checks on Clang.
This requires a trunk build of Clang (the flag was only implemented
& introduced 12 days ago), but at present, full builds will fail
due to an unrelated Clang bug: https://bugs.llvm.org/show_bug.cgi?id=38356
----------------------------------------------------------------------------
diff --git a/build/jam/ArchitectureRules b/build/jam/ArchitectureRules
index e12fdad7c8..f7de079089 100644
--- a/build/jam/ArchitectureRules
+++ b/build/jam/ArchitectureRules
@@ -34,7 +34,7 @@ rule ArchitectureSetup architecture
# - https://dev.haiku-os.org/ticket/10803#comment:4 ;(& subsequent
comments)
# Note that the Linux also does the same:
# -
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a3ca86aea507904148870946d599e07a340b39bf
- if $(gccVersion[1]) >= 3 && $(HAIKU_CC_IS_CLANG_$(architecture)) != 1 {
+ if $(gccVersion[1]) >= 3 {
gccBaseFlags += -fno-delete-null-pointer-checks ;
}
############################################################################
Revision: hrev52140
Commit: 5ad9670f398319f7f48929721ad2b77da737f7d1
URL: https://git.haiku-os.org/haiku/commit/?id=5ad9670f3983
Author: Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date: Tue Jul 31 02:50:30 2018 UTC
intel_extreme, radeon_hd: Use bufferLength instead of B_FILE_NAME_LENGTH.
Thanks korli for the review!
----------------------------------------------------------------------------
diff --git a/src/add-ons/kernel/drivers/graphics/intel_extreme/device.cpp
b/src/add-ons/kernel/drivers/graphics/intel_extreme/device.cpp
index 6a6fd701a0..3a4fdb52a3 100644
--- a/src/add-ons/kernel/drivers/graphics/intel_extreme/device.cpp
+++ b/src/add-ons/kernel/drivers/graphics/intel_extreme/device.cpp
@@ -188,7 +188,7 @@ device_ioctl(void* data, uint32 op, void* buffer, size_t
bufferLength)
case B_GET_ACCELERANT_SIGNATURE:
TRACE("accelerant: %s\n", INTEL_ACCELERANT_NAME);
if (user_strlcpy((char*)buffer, INTEL_ACCELERANT_NAME,
- B_FILE_NAME_LENGTH) < B_OK)
+ bufferLength) < B_OK)
return B_BAD_ADDRESS;
return B_OK;
@@ -210,7 +210,7 @@ device_ioctl(void* data, uint32 op, void* buffer, size_t
bufferLength)
// needed for cloning
case INTEL_GET_DEVICE_NAME:
if (user_strlcpy((char* )buffer, gDeviceNames[info->id],
- B_PATH_NAME_LENGTH) < B_OK)
+ bufferLength) < B_OK)
return B_BAD_ADDRESS;
return B_OK;
diff --git a/src/add-ons/kernel/drivers/graphics/radeon_hd/device.cpp
b/src/add-ons/kernel/drivers/graphics/radeon_hd/device.cpp
index ade305b97f..4fc3fb1bd4 100644
--- a/src/add-ons/kernel/drivers/graphics/radeon_hd/device.cpp
+++ b/src/add-ons/kernel/drivers/graphics/radeon_hd/device.cpp
@@ -186,7 +186,7 @@ device_ioctl(void* data, uint32 op, void* buffer, size_t
bufferLength)
case B_GET_ACCELERANT_SIGNATURE:
TRACE("%s: accelerant: %s\n", __func__,
RADEON_ACCELERANT_NAME);
if (user_strlcpy((char*)buffer, RADEON_ACCELERANT_NAME,
- B_FILE_NAME_LENGTH) < B_OK)
+ bufferLength) < B_OK)
return B_BAD_ADDRESS;
return B_OK;
@@ -208,7 +208,7 @@ device_ioctl(void* data, uint32 op, void* buffer, size_t
bufferLength)
// needed for cloning
case RADEON_GET_DEVICE_NAME:
if (user_strlcpy((char*)buffer, gDeviceNames[info->id],
- B_PATH_NAME_LENGTH) < B_OK)
+ bufferLength) < B_OK)
return B_BAD_ADDRESS;
return B_OK;
