[haiku-commits] Re: haiku: hrev52025 - src/bin build/jam src/add-ons/kernel/file_systems/nfs4 headers/private/drivers src/servers

  • From: Rene Gollent <anevilyak@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 19 Jun 2018 08:38:05 -0400

On Mon, Jun 18, 2018 at 11:20 PM waddlesplash <waddlesplash@xxxxxxxxx> wrote:

Commit:      9216fc01782e67a039b918399d45c8c0c9199d71
URL:         https://git.haiku-os.org/haiku/commit/?id=9216fc01782e
Author:      Augustin Cavalier <waddlesplash@xxxxxxxxx>
Date:        Tue Jun 19 02:06:26 2018 UTC

More class/struct mixup fixes.

Spotted by Clang.

[...]

diff --git a/headers/private/interface/ShapePrivate.h 
b/headers/private/interface/ShapePrivate.h
index 31e201e2d5..e4c2832cfe 100644
--- a/headers/private/interface/ShapePrivate.h
+++ b/headers/private/interface/ShapePrivate.h
@@ -27,7 +27,8 @@
 #define OP_SMALL_ARC_TO_CCW    0x08000000


-struct shape_data : public BReferenceable {
+class shape_data : public BReferenceable {
+public:
        uint32* opList;
        BPoint* ptList;
        int32   opCount;

I don't see the point of this change. struct was chosen intentionally
here due to the default of public member visibility, which there's
nothing wrong with. This isn't a mix-up but deliberate, and as such,
this looks more like a false positive that should be reverted.

Regards,

Rene

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 06-2018