[haiku-commits] haiku: hrev51194 - src/kits/network/libnetapi

  • From: pulkomandy@xxxxxxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 4 Jun 2017 07:52:50 +0200 (CEST)

hrev51194 adds 1 changeset to branch 'master'
old head: 4edf3ea9c1fd8f6903f40763c5c5dd67c1a701c5
new head: 5721d1791e569d2112e0c69ffccd9fde276fe9c0
overview: 
http://cgit.haiku-os.org/haiku/log/?qt=range&q=5721d1791e56+%5E4edf3ea9c1fd

----------------------------------------------------------------------------

5721d1791e56: BHttpTime: Handle sunday properly
  
  Cookies with expiration on a sunday would be misformatted, which could
  lead to websites not recognizing them.
  
  Signed-off-by: Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
  
  Fixes 13543

                                      [ Mark Hellegers <mark@xxxxxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev51194
Commit:      5721d1791e569d2112e0c69ffccd9fde276fe9c0
URL:         http://cgit.haiku-os.org/haiku/commit/?id=5721d1791e56
Author:      Mark Hellegers <mark@xxxxxxxxxxxx>
Date:        Sat Jun  3 18:50:37 2017 UTC
Committer:   Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
Commit-Date: Sun Jun  4 05:47:53 2017 UTC

----------------------------------------------------------------------------

1 file changed, 3 insertions(+), 1 deletion(-)
src/kits/network/libnetapi/HttpTime.cpp | 4 +++-

----------------------------------------------------------------------------

diff --git a/src/kits/network/libnetapi/HttpTime.cpp 
b/src/kits/network/libnetapi/HttpTime.cpp
index 6deaecf..773c08f 100644
--- a/src/kits/network/libnetapi/HttpTime.cpp
+++ b/src/kits/network/libnetapi/HttpTime.cpp
@@ -145,7 +145,9 @@ BHttpTime::ToString(int8 format)
        expirationTm.tm_mday = fDate.Date().Day();
        expirationTm.tm_mon = fDate.Date().Month() - 1;
        expirationTm.tm_year = fDate.Date().Year() - 1900;
-       expirationTm.tm_wday = fDate.Date().DayOfWeek();
+       // strftime starts weekday count at 0 for Sunday,
+       // while DayOfWeek starts at 1 for Monday and thus uses 7 for Sunday
+       expirationTm.tm_wday = fDate.Date().DayOfWeek() % 7;
        expirationTm.tm_yday = 0;
        expirationTm.tm_isdst = 0;
 


Other related posts: