[haiku-commits] Re: haiku: hrev51171 - in src/system/boot: loader platform/efi platform/atari_m68k platform/u-boot platform/pxe_ia32
- From: Fredrik Holmqvist <fredrik.holmqvist@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 17 May 2017 20:44:55 +0000
ons 17 maj 2017 kl 22:08 skrev Jessica Hamilton <
jessica.l.hamilton@xxxxxxxxx>:
This allows the loader to skip BFS partitions that don't contain
a bootable system. Useful when you have a BFS data partition that
comes before the system partition when iterated over.
I don't get the rationale of this change. Why not simply check if the
BFS partition actually contains a bootable system before returning it as
boot partition?
That part is in the generic vfs code. Previously the platform code would
return just one likely partition before giving up and dropping you into the
menu.
If you look at the modified vfs function, you'll see why this change makes
sense.
The logic should already exist to compile the list of boot volumes in
the menu.
Yes, if you want to enter the menu. This allows booting from the first
bootable bfs partition from the disk containing the uefi l loader
automatically
This does make sense, with UEFI you want to just pass in some partitions as
the bootloader is on its own system partition. You could give the loader
extra args about what partition to boot (which is a UX fail imo, especially
if you try to enter a UUID from the firmware)
Haiku needs to be smart enough to do the right thing and only pop up the
boot menu when there are multiple options.
There are a lot of setups to handle here:
* When you boot a CD-ROM or USB-stick with UEFI system partition- (IMO boot
the first BFS partition on same disk. Firmware decided to boot from
USB/CD-Rom: Installation/Recovery)
* When you boot from disk and only have one BFS-partition (IMO: boot it)
* When you boot from disk and have several BFS-partitions (iMO: Only show
menu if several bootable)
* When you boot from disk and have several BFS-partitions on different
disks (IMO: Only show menu if several bootable)
All of them are common and needs good handling.
/Fredrik Holmqvist, TQH
Other related posts:
