[haiku-commits] Re: haiku: hrev50838 - src/apps/haikudepot/ui
- From: Stephan Aßmus <superstippi@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sun, 8 Jan 2017 19:29:29 +0100
Am 08.01.2017 um 08:50 schrieb humdingerb@xxxxxxxxx:
hrev50838 adds 1 changeset to branch 'master'
old head: 1aacfd694057329be4aa51080ad08669e6be6177
new head: d193fb94375a4d7dab8e59d16e8f2ac4129f99bb
overview:
http://cgit.haiku-os.org/haiku/log/?qt=range&q=d193fb94375a+%5E1aacfd694057
----------------------------------------------------------------------------
d193fb94375a: HaikuDepot prefs: Add ellipsis to menu item
As Diver pointed out, the "Manage repositories" opens a window and
should therefore be suffixed with an ellipsis.
Don't remember if this was discussed here or if I learned about it
elsewhere. The criterion of opening a window alone to justify an
ellipsis isn't a very good one. The distinction should be whether the
action is performed or whether the menu item just starts an action and
it requires more input from the user to perform it. (Often that means
the action can be cancelled, too). Here, it is a gray area: The wording
isn't actually precise. What the menu item does is it opens a window
where the user can manage repositories. It doesn't actually manage them.
So if it were named "Open repository manager", it shouldn't have an
ellipsis, since the action is completely performed by opening that
window. That said, I don't propose to change its name to that. Just
saying, not all menu items which open a window should get an ellipsis.
Best regards,
-Stephan
Other related posts:
