[haiku-commits] Re: haiku: hrev49977 - in src: servers/app kits/interface apps preferences/appearance .
- From: Jessica Hamilton <jessica.l.hamilton@xxxxxxxxx>
- To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
- Date: Sun, 10 Jan 2016 18:41:56 +1300
On 5 January 2016 at 17:07, looncraz <looncraz@xxxxxxxxxxx> wrote:
On 1/4/2016 15:41, waddlesplash wrote:
On Mon, Jan 4, 2016 at 3:48 PM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
wrote:
I noticed two regressions, though:
1) The tray background has the wrong color. It's supposed to be darker
than
the menu background.
2) The focus color seems to have been lost, or maybe it's just the
default
button (it has an ugly white border)
Yeah, and there are a couple of other ones with disabled buttons &
focus rings, as well as some in Tracker. I emailed looncraz about all
of these as a heads-up, so he can review & submit some patches for
that.
-waddlesplash
Thanks!
I will review the issues and do some comparisons from before the commit and
afterwards to see what is going on. Some of these issues had been
previously resolved (or so I thought, apparently).
The timing of this could not have been better as I have several days
available to me starting tomorrow.
--The loon
Actually, quite a few visual glitches are due to the default ViewColor
no longer matching the R5 API documentation. See the relevant sections
at
https://www.haiku-os.org/legacy-docs/bebook/BView.html#BView_Graphics
The R5 API states that ViewColor should be white, but now the default
appears to be B_PANEL_BACKGROUND_COLOR via the ViewUIColor API, which
certainly isn't white!
Given this is a breaking change, how do we want to proceed?
I also think that many of the standard controls ought to inherit their
parent colours automatically, rather than using AdoptSystemColors.
This would make using controls like BStringViews, radio buttons, etc.
a lot saner than having to litter the code with AdoptParentColors all
over the place (as I've had to do with the package_daemon windows).
Other related posts:
