hrev49514 adds 1 changeset to branch 'master'
old head: f6f96d9689496b59f54cee888f8611c9b64bfd83
new head: 3749038b534a5948026624805adf1ee14ff4caa6
overview:
http://cgit.haiku-os.org/haiku/log/?qt=range&q=3749038b534a+%5Ef6f96d968949
----------------------------------------------------------------------------
3749038b534a: MouseDownThread: let thread terminate cleanly.
* Killing the thread leaks resources, and it will terminate cleanly and
safely when the destructor exits anyway.
* Fixes #12293. Thanks to ttcoder, jackburton and bonefish for investigating!
* Does not fix #12286. Going to bissect now...
[ Adrien Destugues <pulkomandy@xxxxxxxxx> ]
----------------------------------------------------------------------------
Revision: hrev49514
Commit: 3749038b534a5948026624805adf1ee14ff4caa6
URL: http://cgit.haiku-os.org/haiku/commit/?id=3749038b534a
Author: Adrien Destugues <pulkomandy@xxxxxxxxx>
Date: Fri Aug 7 18:37:11 2015 UTC
Ticket: https://dev.haiku-os.org/ticket/12286
Ticket: https://dev.haiku-os.org/ticket/12293
----------------------------------------------------------------------------
1 file changed, 1 insertion(+), 7 deletions(-)
headers/private/shared/Thread.h | 8 +-------
----------------------------------------------------------------------------
diff --git a/headers/private/shared/Thread.h b/headers/private/shared/Thread.h
index 79d062f..7a47213 100644
--- a/headers/private/shared/Thread.h
+++ b/headers/private/shared/Thread.h
@@ -365,11 +365,6 @@ MouseDownThread<View>::MouseDownThread(View* view,
template<class View>
MouseDownThread<View>::~MouseDownThread()
{
- if (fThreadID > 0) {
- kill_thread(fThreadID);
- // dead at this point
- TRESPASS();
- }
}
@@ -393,7 +388,6 @@ MouseDownThread<View>::TrackBinder(void* castToThis)
MouseDownThread* self = static_cast<MouseDownThread*>(castToThis);
self->Track();
// dead at this point
- TRESPASS();
return B_OK;
}
@@ -427,9 +421,9 @@ MouseDownThread<View>::Track()
}
delete this;
- ASSERT(!"should not be here");
}
+
} // namespace BPrivate
using namespace BPrivate;
