[haiku-commits] Re: haiku: hrev49503 - src/kits/media src headers/os/media

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 5 Aug 2015 16:49:42 +0200

Hi,

Am 04.08.2015 um 12:16 schrieb Dario Casalinuovo:

Hi,

What's confusing is the variable is called "lateness", yet for most of
the time it doesn't contain the lateness, but the time of the event.


I think this can confuse if someone don't understand at all the code.
But i changed the variable name anyway.

One goal when writing code is that it should not be confusing to someone reading it who does not (yet) understand it. That's the whole point, you should write it in such a way that people can understand it /faster/.

Arguing that code is only confusing as long as you don't understand it, is a circular argument. "Confusing" means "harder to understand" and you should strive to avoid it.

Basically, if someone complains about your code being confusing, they are almost right by definition, since otherwise they wouldn't complain in the first place. Ok, they might be morons, but you should always take it seriously at first. ;-)

Of course I don't mean to blow things out of proportion based on a variable name/usage, I only keep arguing because you refuse to accept this well-meaning critique and it is important on principle.

Best regards & please don't take it the wrong way,
-Stephan



Other related posts: