[haiku-commits] Re: haiku: hrev49324 - headers/build/os

  • From: Alexander von Gluck IV <kallisti5@xxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 25 Jun 2015 11:34:52 -0500

On , Adrien Destugues wrote:

On Thu, Jun 25, 2015 at 06:06:19AM +0200, kallisti5@xxxxxxxxxxx wrote:
#if __GNUC__ == 2
# define B_HAIKU_ABI
B_HAIKU_ABI_GCC_2_HAIKU
-#elif __GNUC__ == 3 || __GNUC__ == 4
+#elif __GNUC__ == 3 || __GNUC__ == 4 || __GNUC__ == 5
# define B_HAIKU_ABI
B_HAIKU_ABI_GCC_4
#else
# error Unsupported gcc version!

There are ABI changes to the C++ runtime in GCC5. Do we want a new
constant here? Apparently there is some backward compatibility suport
this time:
https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_dual_abi.html

Yeah.. this raises some questions about usage of this header for the buildhost
target (local machine running the build) vs the haiku target (haiku abi)

I wonder if these checks should be wrapped in __HAIKU__ to pick up on
buildhost vs haiku targets?

I'm guessing things like the filesystem tools that the buildhost compiles
and runs are at fault here.

-- Alex

Other related posts: