[haiku-commits] Re: haiku: hrev49265 - src/add-ons/kernel/network/protocols/tcp headers/posix/sys

From: Augustin Cavalier <waddlesplash@xxxxxxxxx>
To: haiku-commits@xxxxxxxxxxxxx
Date: Wed, 10 Jun 2015 11:52:20 -0400

On Wed, Jun 10, 2015 at 11:51 AM, Jérôme Duval <jerome.duval@xxxxxxxxx> wrote:

@@ -794,12 +796,11 @@ TCPEndpoint::SendData(net_buffer *buffer)
return EDESTADDRREQ;
if (!is_writable(fState) && !is_establishing(fState)) {
// we only send signals when called from userland
- if (gStackModule->is_syscall())
+ if (gStackModule->is_syscall() && (flags & MSG_NOSIGNAL !=
0))
send_signal(find_thread(NULL), SIGPIPE);

Isn't it reversed? I would have used == 0.

Regardless of which it is, this line broke the x86_64 build (or maybe
all builds? that one just failed first) due to -Werror:
http://buildbot.haiku-os.org/builders/haiku-repository-x86_64/builds/1631

-Augustin

References:
- [haiku-commits] haiku: hrev49265 - src/add-ons/kernel/network/protocols/tcp headers/posix/sys
  - From: pulkomandy
- [haiku-commits] Re: haiku: hrev49265 - src/add-ons/kernel/network/protocols/tcp headers/posix/sys
  - From: Jérôme Duval

Other related posts:

» [haiku-commits] haiku: hrev49265 - src/add-ons/kernel/network/protocols/tcp headers/posix/sys- pulkomandy
» [haiku-commits] Re: haiku: hrev49265 - src/add-ons/kernel/network/protocols/tcp headers/posix/sys- Jérôme Duval
» [haiku-commits] Re: haiku: hrev49265 - src/add-ons/kernel/network/protocols/tcp headers/posix/sys - Augustin Cavalier