[haiku-commits] haiku: hrev48967 - src/preferences/network

  • From: axeld@xxxxxxxxxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 31 Mar 2015 18:03:04 +0200 (CEST)

hrev48967 adds 1 changeset to branch 'master'
old head: a526734858867c41ff681537f4aea1a6fd687261
new head: 213f3cdb6964254f12624282937b44de50549c06
overview: 
http://cgit.haiku-os.org/haiku/log/?qt=range&q=213f3cdb6964+%5Ea52673485886

----------------------------------------------------------------------------

213f3cdb6964: Network: preselect first item, make device view resizable.
  
  * After start, the first item will now be selected.
  * The InterfaceAddressView will no longer restrict its width, so
    that the window doesn't have to be resized anymore when switching
    to it.
  * This implements ticket #11923.

                                   [ Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev48967
Commit:      213f3cdb6964254f12624282937b44de50549c06
URL:         http://cgit.haiku-os.org/haiku/commit/?id=213f3cdb6964
Author:      Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
Date:        Tue Mar 31 16:00:23 2015 UTC

Ticket:      https://dev.haiku-os.org/ticket/11923

----------------------------------------------------------------------------

2 files changed, 10 insertions(+), 4 deletions(-)
src/preferences/network/InterfaceAddressView.cpp | 9 +++++----
src/preferences/network/NetworkWindow.cpp        | 5 +++++

----------------------------------------------------------------------------

diff --git a/src/preferences/network/InterfaceAddressView.cpp 
b/src/preferences/network/InterfaceAddressView.cpp
index 5584be1..5c79a17 100644
--- a/src/preferences/network/InterfaceAddressView.cpp
+++ b/src/preferences/network/InterfaceAddressView.cpp
@@ -74,7 +74,7 @@ InterfaceAddressView::InterfaceAddressView(int family,
        fModeField->SetToolTip(
                B_TRANSLATE("The method for obtaining an IP address"));
 
-       float minimumWidth = be_control_look->DefaultItemSpacing() * 16;
+       float minimumWidth = be_control_look->DefaultItemSpacing() * 15;
 
        fAddressField = new IPAddressControl(fFamily, B_TRANSLATE("IP 
Address:"),
                NULL);
@@ -96,8 +96,6 @@ InterfaceAddressView::InterfaceAddressView(int family,
 
        fApplyButton = new BButton("apply", B_TRANSLATE("Apply"),
                new BMessage(kMsgApply));
-       fApplyButton->SetExplicitAlignment(
-               BAlignment(B_ALIGN_RIGHT, B_ALIGN_VERTICAL_UNSET));
 
        fSettings.GetInterface(interface, fOriginalSettings);
        _UpdateFields();
@@ -109,7 +107,10 @@ InterfaceAddressView::InterfaceAddressView(int family,
                        .AddTextControl(fNetmaskField, 0, 2, B_ALIGN_RIGHT)
                        .AddTextControl(fGatewayField, 0, 3, B_ALIGN_RIGHT)
                .End()
-               .Add(fApplyButton)
+               .AddGroup(B_HORIZONTAL)
+                       .AddGlue()
+                       .Add(fApplyButton)
+               .End()
                .AddGlue();
 }
 
diff --git a/src/preferences/network/NetworkWindow.cpp 
b/src/preferences/network/NetworkWindow.cpp
index a7964b4..b9b42fe 100644
--- a/src/preferences/network/NetworkWindow.cpp
+++ b/src/preferences/network/NetworkWindow.cpp
@@ -160,6 +160,11 @@ NetworkWindow::NetworkWindow()
        _ScanAddOns();
        _UpdateRevertButton();
 
+       fListView->Select(0);
+       _SelectItem(fListView->ItemAt(0));
+               // Call this manually, so that CenterOnScreen() below already
+               // knows the final window size.
+
        // Set size of the list view from its contents
        float width;
        float height;


Other related posts:

  • » [haiku-commits] haiku: hrev48967 - src/preferences/network - axeld