[haiku-commits] Re: haiku: hrev48491 - src/preferences/filetypes
- From: Adrien Destugues <pulkomandy@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 12 Dec 2014 21:31:45 +0100
On Fri, Dec 12, 2014 at 09:16:51PM +0100, Stephan Aßmus wrote:
> Am 12.12.2014 19:32, schrieb Adrien Destugues:
> I probably came across harsher than I intended. But hacking code until it
> looks like it works is seldem the best strategy. Time is better spend
> reading and understanding the code to find the proper fix, or just asking
> about it. You should be confident to have the proper fix first. If you need
> to "fix" something the exact same way in three places, it /cannot/ be the
> proper fix. And if the documentation was lacking, that needs to be fixed
> too. It's just how open source works, you have to try to leave the place in
> better shape than you found it. Otherwise the code-base slowly degrades.
>
> All that being said, I really hope it doesn't make you feel bad! I am really
> happy about the work you do, it's a joy to read the stream of commits
> everyday and get so many long standing issues fixed!
Thanks; now I have enough information to fix the problem better, and
maybe even improve the documentation. I'm a bit bitter about the lack of
docs and tests, I try to write some when I can but I'm starting to fear
modifying core parts of the code and fixing bugs in the apps instead
because I feel I may break more things elsewhere. Without tests and docs
the quality of the code-base degrades, and no one dares to fix it after
some time.
I thought my fix was correct because, first it did look correct when
testing that window, and second, there was no documentation on
SetExplicitMinSize, so I got its meaning wrong. And yes, obviously this
should be moved one layer down in BBox.
--
Adrien.
Other related posts:
