[haiku-commits] Re: haiku: hrev48474 - src/add-ons/media/plugins/ape_reader
- From: Adrien Destugues <pulkomandy@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 10 Dec 2014 10:25:38 +0100
On Wed, Dec 10, 2014 at 09:01:10AM +0000, Simon Taylor wrote:
> On 10 Dec 2014, at 08:40, pulkomandy@xxxxxxxxxxxxx wrote:
>
> > * I'm not sure why MediaPlayer is trying to seek to the position it
> > already is at, but we can make it work, so why not.
>
> Are you planning to investigate this in MediaPlayer? If it happens for all
> formats it seems likely to be non-optimal for other decoders too.
Not really, I'm currently more interested in fixing bugs, rather than
optimizing code.
It seems MediaPlayer is using its own mixing and resampling code,
where it could instead rely on the system mixer. And it is doing these
seeks because it also implements some kind of frame caching system, I
guess in an attempt to reduce disk access when for example reading from
audio CDs.
As long as this does not cause any problem, I don't see a need for
fixing (or rather, there are more urgent issues). Probably this would
need a review when we get to implementing streaming support.
--
Adrien.
Other related posts:
