[haiku-commits] haiku: hrev48419 - src/kits/interface

  • From: jerome.duval@xxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 2 Dec 2014 21:51:56 +0100 (CET)

hrev48419 adds 1 changeset to branch 'master'
old head: 4f6ee868818f31a5f96b81acbf502b94ceee3024
new head: fec56923298355f41c6146c7e570153eb2279983
overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=fec5692+%5E4f6ee86

----------------------------------------------------------------------------

fec5692: ColumnListView: Fix two bugs reported by Coverity
  
  * Fix Coverity bug 991147: Copy-paste error
  * Fix Coverity bug 991264: Dereference after null check
  
  Signed-off-by: Jérôme Duval <jerome.duval@xxxxxxxxx>

                                 [ Chirayu Desai <chirayudesai1@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev48419
Commit:      fec56923298355f41c6146c7e570153eb2279983
URL:         http://cgit.haiku-os.org/haiku/commit/?id=fec5692
Author:      Chirayu Desai <chirayudesai1@xxxxxxxxx>
Date:        Tue Dec  2 17:55:27 2014 UTC
Committer:   Jérôme Duval <jerome.duval@xxxxxxxxx>
Commit-Date: Tue Dec  2 20:28:45 2014 UTC

----------------------------------------------------------------------------

1 file changed, 1 insertion(+), 1 deletion(-)
src/kits/interface/ColumnListView.cpp | 2 +-

----------------------------------------------------------------------------

diff --git a/src/kits/interface/ColumnListView.cpp 
b/src/kits/interface/ColumnListView.cpp
index ce8237e..3931618 100644
--- a/src/kits/interface/ColumnListView.cpp
+++ b/src/kits/interface/ColumnListView.cpp
@@ -1292,7 +1292,7 @@ BColumnListView::SwapRows(int32 index1, int32 index2, 
BRow* parentRow1,
        if (parentRow2 == NULL)
                container2 = fOutlineView->RowList();
        else
-               container2 = parentRow1->fChildList;
+               container2 = parentRow2->fChildList;
 
        if (container2 == NULL)
                return false;


Other related posts:

  • » [haiku-commits] haiku: hrev48419 - src/kits/interface - jerome . duval