[haiku-commits] Re: haiku: hrev48109 - src/system/kernel/arch/arm
- From: François Revol <revol@xxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 27 Oct 2014 11:49:23 +0100
On 27/10/2014 01:50, Ithamar R. Adema wrote:
> Hi Pawel,
>
> On Mon, Oct 27, 2014 at 1:30 AM, Paweł Dziepak <pdziepak@xxxxxxxxxxx> wrote:
>
>> 2014-10-26 15:23 GMT-07:00 <ithamar@xxxxxxxxxxxxxxxxxxx>:
>> These warnings are pretty uselss, aren't they? I mean, all they do is to
>> produce a number of build messages so big that nobody is going to pay any
>> attention to them. It would be probably a good idea to replace all of these
>> with something like:
>>
>> panic("Function %s is not implemented yet.", __PRETTY_FUNCTION__);
>>
>> This way we would only get an information when the function is actually
>> needed and, unlike compile time warnings, that information would be hard to
>> miss (what hopefully would prevent problems similar to the one this patch
>> fixes).
>>
>
> Totally agree, and already had a similar discussion with Ingo about this,
> and planning to clean them all up this coding sprint. Just want to get some
> actual functionality done first ;-)
Well,back when I added them everywhere starting with m68k, panic() was
not even implemented anyway :D
François.
Other related posts:
