[haiku-commits] Re: haiku: hrev48061 - build/jam/repositories/HaikuPorts src/bin/network/tcpdump/libpcap

  • From: Jessica Hamilton <jessica.l.hamilton@xxxxxxxxx>
  • To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
  • Date: Tue, 21 Oct 2014 16:11:27 +1300

On Tuesday, 21 October 2014, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:

> On 10/21/2014 01:59 AM, jessica.l.hamilton@xxxxxxxxx wrote:
>
>> diff --git a/src/bin/network/tcpdump/libpcap/Jamfile
>> b/src/bin/network/tcpdump/libpcap/Jamfile
>> index 36e87f1..d5e6819 100644
>> --- a/src/bin/network/tcpdump/libpcap/Jamfile
>> +++ b/src/bin/network/tcpdump/libpcap/Jamfile
>> @@ -27,5 +27,6 @@ StaticLibrary libpcap.a :
>>         version.c
>>   ;
>>
>> -# scanner.l includes the generated grammar.h
>> -Includes [ FGristFiles scanner.l ] : [ FGristFiles grammar.h ] ;
>> +# scanner.l includes the generated grammar.h, but we need to
>> +# declare the dependency from .o to .c
>> +Depends [ FGristFiles scanner.o ] : [ FGristFiles grammar.c ] ;
>>
>
> Unless the generated scanner.c includes grammar.c -- which it doesn't seem
> to do -- this is technically just wrong. Please explicitly document it as a
> work-around for a bug in jam.
>
> That being said, a few years back a patch had been proposed on the jamming
> mailing list to address an issue with concurrent jobs, which might be
> exactly the one we're seeing here. I never found the motivation to check it
> out, though.
>

Mm, after looking at a slightly similar case, the bug appears to be related
to rules that generate more than one file. But then again, I didn't look at
it that closely.

A similar warning can be seen for the Devices app when awk generates two
header files in a single rule/action.

Other related posts: