[haiku-commits] Re: haiku: hrev47425 - src/apps/webpositive src/kits/network/libnetapi headers/os/net

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 25 Jun 2014 11:10:13 +0200 (CEST)

> On June 25, 2014 at 10:46 AM pulkomandy@xxxxxxxxxxxxx wrote:
> @@ -372,6 +372,7 @@ void
>  BrowserApp::_RefsReceived(BMessage* message, int32* _pagesCreated,
>       bool* _fullscreen)
>  {
> +     puts("refs!");

This one probably should not have been part of the commit.

> +             BUrl url(path);
> +             window = _CreateNewPage(url.UrlString(), window, fullscreen,
> +                     pagesCreated == 0);

Should be more compact to write as:

window = _CreateNewPage(BUrl(path).UrlString(), window, fullscreen,
                        pagesCreated == 0);

> -                     CurrentWebView()->LoadURL(path.Path());
> +
> +                     BUrl url(path);
> +                     CurrentWebView()->LoadURL(url);

Same here.

Bye,
   Axel.

Other related posts: