[haiku-commits] Re: haiku: hrev47424 - headers/build/host/haiku_host
- From: pulkomandy <pulkomandy@xxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 25 Jun 2014 21:35:47 +0200
On Wed, Jun 25, 2014 at 09:22:46PM +0200, Ingo Weinhold wrote:
> On 25.06.2014 09:01, pulkomandy@xxxxxxxxxxxxx wrote:
> >6bcbdcc: Use current Errors.h when building libbe_build
> >
> > This allows adding new error codes to the libbe_build without breaking
> > the build on older Haiku versions.
> >
> > Fixes the build for the newly introduced B_PARTIAL_READ and
> > B_PARTIAL_WRITE.
>
> Strictly speaking this is not correct. The error codes are a libroot
> feature, which is used from the host. Since only functions like strerror()
> and perror() are affected, it shouldn't harm, though. Without also emulating
> libroot there isn't a good solution, I'm afraid.
Since this is used only on Haiku, I'm assuming that we don't change
error code values, and only add or remove some errors. Then, all we risk
is some "unknown error" messages in strerror and perror for the newly
introduced codes. I think this is an acceptable compromise.
>
> Unless I'm much mistaken, the file can as well be removed. Its only purpose
> was to shadow the header in headers/build/os/support/.
I'll try that.
--
Adrien.
Other related posts:
