[haiku-commits] Re: haiku: hrev47408 - src/kits/tracker
- From: John Scipione <jscipione@xxxxxxxxx>
- To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
- Date: Mon, 23 Jun 2014 17:00:41 -0400
On Sun, Jun 22, 2014 at 5:10 PM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
> On 06/21/2014 04:34 AM, jscipione@xxxxxxxxx wrote:
>>
>> switch (mode) {
>> case 0:
>> return fMode1Frame;
>> +
>> case 1:
>> return fMode2Frame;
>> +
>> case 2:
>> return fMode3Frame;
>> }
>
>
> I don't mind blank lines here, but they are definitely not in our style
> guide; it's just your preference to put them there.
While this isn't specifically stated in the guidelines it is hinted at
in the examples which use a blank line between each case. The idea is
to visually show which cases fall through and which don't.
> Since there is at least one tracker branch (aldeck's tracker_layout) waiting
> for a motivated developer, doing superfluous changes like these should be
> avoided, though.
tracker_layout is dead, it's 2 years out of date and needs serious
refactoring to be merged. Even then it is hard to tell what is
experimental and what is fleshed out. I'm afraid that if someone
wanted to rework Tracker to use the layout APIs they'd be better off
starting from scratch, the merge would be too painful. I'm not too
worried about that though because we don't need it for R1, Tracker
works fine in its current form with the caveat that there are some
bugs that need fixing.
Other related posts:
