[haiku-commits] Re: haiku: hrev47177 - in src: kits/media apps/showimage
- From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sun, 27 Apr 2014 22:37:30 +0200
On 04/27/2014 06:04 PM, pulkomandy@xxxxxxxxxxxxx wrote:
* Fix the condition so that big images are fitted to the window on first
time only if the option is set.
* Small images are never stretched to the window size, as this isn't
very useful.
[...]
float fitToBoundsZoom = _FitToBoundsZoom();
- if (!fStretchToBounds && fitToBoundsZoom > 1.0f)
+ if (!fStretchToBounds || fitToBoundsZoom > 1.0f)
SetZoom(1.0f);
else
SetZoom(fitToBoundsZoom);
Maybe I'm getting old, but that just doesn't look right.
The stretch-to-bounds option is only meant for smaller images. That's
why it's an option, it only makes sense for some images. You just broke
that option. Please revert.
Bye,
Axel.
Other related posts:
