On Sat, Feb 15, 2014 at 11:52 AM, <axeld@xxxxxxxxxxxxxxxx> wrote: > +dprintf("TRIM AHCI:\n"); > +for (uint32 i = 0; i < lbaRangeCount; i++) { > + uint64 value = B_HOST_TO_LENDIAN_INT64(lbaRanges[i]); > + dprintf("[3%" B_PRIu32 "] %" B_PRIu64 " : %" B_PRIu64 "\n", i, > + value >> 48, value & ((uint64)1 << 48) - 1); > +} > + Looks like this triggers a warning (failure) in gcc4: C++ /usr/home/builder/buildbot-slave/x86_64-any-host/generated.x86_64/objects/haiku/x86_64/release/add-ons/kernel/busses/scsi/ahci/ahci_port.o /usr/home/builder/buildbot-slave/haiku/src/add-ons/kernel/busses/scsi/ahci/ahci_port.cpp: In member function 'void AHCIPort::ScsiUnmap(scsi_ccb*, scsi_unmap_parameter_list*)': /usr/home/builder/buildbot-slave/haiku/src/add-ons/kernel/busses/scsi/ahci/ahci_port.cpp:900:22: error: suggest parentheses around '-' in operand of '&' [-Werror=parentheses] value >> 48, value & ((uint64)1 << 48) - 1); ^ cc1plus: all warnings being treated as errors /usr/home/builder/buildbot-slave/cross-tools-x86_64/cross-tools-x86_64/bin/x86_64-unknown-haiku-gcc -c "/usr/home/builder/buildbot-slave/haiku/src/add-ons/kernel/busses/scsi/ahci/ahci_port.cpp" -O -Wall -Wno-trigraphs -Wno-multichar -Werror -Wno-error=uninitialized -Wno-unused-but-set-variable -pipe -fno-strict-aliasing -fno-tree-vrp -Wno-array-bounds -nostdinc -Wno-deprecated -pipe -fno-strict-aliasing -fno-tree-vrp -Wno-array-bounds -nostdinc -Wno-deprecated -pipe -fno-strict-aliasing -fno-tree-vrp -Wno-array-bounds -finline -fno-builtin -ffreestanding -fno-exceptions -fno-use-cxa-atexit -mno-red-zone -fno-omit-frame-pointer -D_KERNEL_MODE -DARCH_x86_64 -DB_USE_BUILTIN_ATOMIC_FUNCTIONS -DBOOT_ARCHIVE_IMAGE_OFFSET=300 -D__HAIKU_PRIMARY_PACKAGING_ARCH=\"x86_64\" -DHAIKU_DISTRO_COMPATIBILITY_DEFAULT -DHAIKU_INCLUDE_PATENTED_CODE=0 -DHAIKU_TARGET_PLATFORM_HAIKU -iquote /usr/home/builder/buildbot-slave/haiku/build/user_config_headers -iquote /usr/home/builder/buildbot-slave/haiku/build/config_headers -iquote /usr/home/builder/buildbot-slave/haiku/src/add-ons/kernel/busses/scsi/ahci -iquote /usr/home/builder/buildbot-slave/x86_64-any-host/generated.x86_64/objects/common/add-ons/kernel/busses/scsi/ahci -iquote /usr/home/builder/buildbot-slave/x86_64-any-host/generated.x86_64/objects/freebsd/x86/common/add-ons/kernel/busses/scsi/ahci -iquote /usr/home/builder/buildbot-slave/x86_64-any-host/generated.x86_64/objects/haiku/x86_64/common/add-ons/kernel/busses/scsi/ahci -I /usr/home/builder/buildbot-slave/haiku/headers/private/drivers -I /usr/home/builder/buildbot-slave/haiku/headers/private/. -I /usr/home/builder/buildbot-slave/haiku/headers/private/kernel -I /usr/home/builder/buildbot-slave/haiku/headers/private/libroot -I /usr/home/builder/buildbot-slave/haiku/headers/private/shared -I /usr/home/builder/buildbot-slave/haiku/headers/private/kernel/boot/platform/bios_ia32 -I /usr/home/builder/buildbot-slave/haiku/headers/private/kernel/arch/x86 -I /usr/home/builder/buildbot-slave/x86_64-any-host/generated.x86_64/objects/haiku/x86_64/common/system/kernel -I /usr/home/builder/buildbot-slave/haiku/headers/private/. -I /usr/home/builder/buildbot-slave/haiku/headers/private/system -I /usr/home/builder/buildbot-slave/haiku/headers/private/system/arch/x86_64 -I /usr/home/builder/buildbot-slave/haiku/src/add-ons/kernel/bus_managers/ata -I /usr/home/builder/buildbot-slave/cross-tools-x86_64/cross-tools-x86_64/lib/gcc/x86_64-unknown-haiku/4.8.2/../../../../x86_64-unknown-haiku/include/c++/4.8.2 -I /usr/home/builder/buildbot-slave/cross-tools-x86_64/cross-tools-x86_64/lib/gcc/x86_64-unknown-haiku/4.8.2/../../../../x86_64-unknown-haiku/include/c++/4.8.2/x86_64-unknown-haiku -I /usr/home/builder/buildbot-slave/cross-tools-x86_64/cross-tools-x86_64/lib/gcc/x86_64-unknown-haiku/4.8.2/../../../../x86_64-unknown-haiku/include/c++/4.8.2/backward -I /usr/home/builder/buildbot-slave/cross-tools-x86_64/cross-tools-x86_64/lib/gcc/x86_64-unknown-haiku/4.8.2/../../../../x86_64-unknown-haiku/include/c++/4.8.2/ext -I /usr/home/builder/buildbot-slave/cross-tools-x86_64/cross-tools-x86_64/lib/gcc/x86_64-unknown-haiku/4.8.2/include -I /usr/home/builder/buildbot-slave/cross-tools-x86_64/cross-tools-x86_64/lib/gcc/x86_64-unknown-haiku/4.8.2/include-fixed -I /usr/home/builder/buildbot-slave/haiku/headers -I /usr/home/builder/buildbot-slave/haiku/headers/posix -I /usr/home/builder/buildbot-slave/haiku/headers/glibc -I /usr/home/builder/buildbot-slave/haiku/headers/os -I /usr/home/builder/buildbot-slave/haiku/headers/os/add-ons -I /usr/home/builder/buildbot-slave/haiku/headers/os/add-ons/file_system -I /usr/home/builder/buildbot-slave/haiku/headers/os/add-ons/graphics -I /usr/home/builder/buildbot-slave/haiku/headers/os/add-ons/input_server -I /usr/home/builder/buildbot-slave/haiku/headers/os/add-ons/registrar -I /usr/home/builder/buildbot-slave/haiku/headers/os/add-ons/screen_saver -I /usr/home/builder/buildbot-slave/haiku/headers/os/add-ons/tracker -I /usr/home/builder/buildbot-slave/haiku/headers/os/app -I /usr/home/builder/buildbot-slave/haiku/headers/os/device -I /usr/home/builder/buildbot-slave/haiku/headers/os/drivers -I /usr/home/builder/buildbot-slave/haiku/headers/os/game -I /usr/home/builder/buildbot-slave/haiku/headers/os/interface -I /usr/home/builder/buildbot-slave/haiku/headers/os/kernel -I /usr/home/builder/buildbot-slave/haiku/headers/os/locale -I /usr/home/builder/buildbot-slave/haiku/headers/os/media -I /usr/home/builder/buildbot-slave/haiku/headers/os/mail -I /usr/home/builder/buildbot-slave/haiku/headers/os/midi -I /usr/home/builder/buildbot-slave/haiku/headers/os/midi2 -I /usr/home/builder/buildbot-slave/haiku/headers/os/net -I /usr/home/builder/buildbot-slave/haiku/headers/os/storage -I /usr/home/builder/buildbot-slave/haiku/headers/os/support -I /usr/home/builder/buildbot-slave/haiku/headers/os/translation -I /usr/home/builder/buildbot-slave/haiku/headers/private/. -o "/usr/home/builder/buildbot-slave/x86_64-any-host/generated.x86_64/objects/haiku/x86_64/release/add-ons/kernel/busses/scsi/ahci/ahci_port.o" ; ...failed C++ /usr/home/builder/buildbot-slave/x86_64-any-host/generated.x86_64/objects/haiku/x86_64/release/add-ons/kernel/busses/scsi/ahci/ahci_port.o ...