[haiku-commits] Re: haiku: hrev46859 - src/kits/shared
- From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 12 Feb 2014 11:44:12 +0100 (CET)
> On February 12, 2014 at 9:49 AM pulkomandy@xxxxxxxxxxxxx wrote:
> @@ -87,7 +87,7 @@ ZlibDecompressor::DecompressNext(const void* input, size_t
> inputSize)
> if (fStream.avail_out < sizeof(outputBuffer)) {
> status_t error = fOutput->Write(outputBuffer,
> sizeof(outputBuffer) - fStream.avail_out);
> - if (error != B_OK)
> + if (error < B_OK)
> return error;
> }
> }
> @@ -116,7 +116,7 @@ ZlibDecompressor::Finish()
> if (fStream.avail_out < sizeof(outputBuffer)) {
> status_t error = fOutput->Write(outputBuffer,
> sizeof(outputBuffer) - fStream.avail_out);
> - if (error != B_OK)
> + if (error < B_OK)
> return error;
If that's indeed a mixup, then please also fix the type and the name of the
variable!
Please keep the code quality as high as possible, and always try to make the
code as understandable as possible; your changes were rather messy on that
front.
Bye,
Axel.
Other related posts:
