[haiku-commits] Re: haiku: hrev46654 - src/kits/network/libnetapi
- From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 10 Jan 2014 15:37:28 +0100
Am 10/01/2014 15:31, schrieb pulkomandy@xxxxxxxxxxxxx:
+ ssize_t chunkSize;
+ char chunk[4096];
+ while ((chunkSize = file.Read(chunk, sizeof(chunk))) >
0)
+ fListener->DataReceived(this, chunk, chunkSize);
+ }
[...]
+ return B_PROT_SUCCESS;
This error code should be removed - we already have B_OK and B_NO_ERROR
for that purpose. Additionally, PROT should not be abbreviated.
This code eats file read errors. Is that how it should work?
Bye,
Axel.
Other related posts:
