[haiku-commits] Re: haiku: hrev46509 - src/system/kernel/fs

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 08 Dec 2013 15:21:36 +0100

Am 08/12/2013 15:16, schrieb Ingo Weinhold:
On 12/08/2013 03:07 PM, Axel Dörfler wrote:
Am 08/12/2013 11:36, schrieb revol@xxxxxxx:
+    for (size_t i = 0;
+        i < vecCount && subRequestCount < kMaxSubRequests && error ==
B_OK;
+        i++) {
          off_t vecOffset = vecs[i].offset;
This looks incorrectly indented. The contents of the for() should be
indented two tabs, not just one.
While I would prefer it that way, too, so far we have indented "if" and
"while" conditions and "for" statements only one additional level,
unless some subexpression was wrapped. The coding guidelines don't offer
any "for" example, but some for "if" which work that way.

Then just let's add this example to the guidelines; the way it's done here just makes the code less readable.

Bye,
   Axel.

Other related posts: