[haiku-commits] Re: haiku: hrev46487 - in src/apps/debugger: controllers dwarf

  • From: Ingo Weinhold <ingo_weinhold@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 05 Dec 2013 01:15:31 +0100

On 12/05/2013 01:08 AM, Rene Gollent wrote:

On 12/4/13, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:

Did/does that actually work? The comment says "See if our image is in
any of the system locations.", but the comparison is "strncmp(fName,
basePath.Path(), strlen(basePath.Path())) == 0" with basePath referring
to one of the *_DEVELOP_DIRECTORY directories. So that should work only,
if the image file lives in one of those. Or do I miss something?


Looks like that was actually introduced by you in
38fa81bf8f0ccc37a615a9f5bd333f9b781322b3 when refactoring for the
removal of common, it previously looked in the system/common/config
folders directly, and then appended develop/debug/ accordingly if a
match was found. Will fix.
Ah, thanks! I thought I recalled having seen the feature work at some point. Apparently before I broke it. :-) 

CU, Ingo

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 12-2013