[haiku-commits] Re: haiku: hrev46441 - src/add-ons/media/plugins/ffmpeg

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 25 Nov 2013 14:21:50 +0100

Hi,

On 25.11.2013 14:12, pulkomandy@xxxxxxxxxxxxx wrote:
diff --git a/src/add-ons/media/plugins/ffmpeg/AVFormatReader.cpp 
b/src/add-ons/media/plugins/ffmpeg/AVFormatReader.cpp
index 7531060..b10b62b 100644
--- a/src/add-ons/media/plugins/ffmpeg/AVFormatReader.cpp
+++ b/src/add-ons/media/plugins/ffmpeg/AVFormatReader.cpp
@@ -242,7 +242,8 @@ StreamBase::~StreamBase()
                avformat_close_input(&fContext);
        av_free_packet(&fPacket);
        av_free(fContext);
-       av_free(fIOContext->buffer);
+       if(fIOContext)
+               av_free(fIOContext->buffer);
        av_free(fIOContext);
  }

Please do not introduce coding style errors. It's "if (fIOContext != NULL)". I also saw the missing space after "if" in another recent commit of yours.

Thanks & best regards,
-Stephan





Other related posts: