[haiku-commits] Re: haiku: hrev46275 - src/add-ons/kernel/bus_managers/pci/arch/x86
- From: pulkomandy <pulkomandy@xxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 22 Oct 2013 07:48:15 +0200
On Mon, Oct 21, 2013 at 10:27:34PM +0200, korli@xxxxxxxxxxxxxxxx wrote:
> hrev46275 adds 2 changesets to branch 'master'
> old head: ce2d7d5ac8d220cb661fd12529fd5c88f5d80d6e
> new head: 30794c2d793f5b581efc9329017853882348fc69
> overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=30794c2+%5Ece2d7d5
>
> ----------------------------------------------------------------------------
>
> 004a268: Fix dereference of a null pointer
> - if (rsdt != NULL
> - && strncmp(rsdt->signature, ACPI_RSDT_SIGNATURE, 4) !=
> 0) {
> + if (rsdt == NULL) {
> + TRACE(("acpi: couldn't map rsdt header\n"));
> + return B_ERROR;
> + }
> + if (strncmp(rsdt->signature, ACPI_RSDT_SIGNATURE, 4) != 0) {
As far as I know, the && operator in C is sort-circuit, so if rsdt is
NULL, the second part of the condition isn't tested. Am I wrong ?
--
Adrien.
Other related posts:
