[haiku-commits] Re: haiku: hrev46041 - src/preferences/screensaver
- From: John Scipione <jscipione@xxxxxxxxx>
- To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
- Date: Mon, 16 Sep 2013 19:04:44 -0400
On Tue, Sep 10, 2013 at 7:07 PM, Rene Gollent <anevilyak@xxxxxxxxx> wrote:
> On Sep 10, 2013 6:49 PM, <jscipione@xxxxxxxxx> wrote:
>> fb90f7f: ScreenSaver: ScrollToSelection off-by-one
>> For some reason calling PopulateScreenSaver() list in AllAttached()
>> scrolls the selection off-by-one, so, call PopulateScreenSaverList()
>> in AttachedToWindow() and then call ScrollToSelection() again in
>> AllAttached() which seems to fix the problem.
>
> Please revert this and fix it properly. I don't know how many times you need
> to be told to fix bugs properly, and not just add crappy workarounds that
> hide the underlying problem. If it winds up off by one, then find out why
> and fix that.
I've now reverted this commit in hrev46079 after the underlying issue
was fixed by Siarzhuk Zharski in hrev46066.
Thanks go to Siarzhuk for fixing the underlying issue and Rene for
pointing out the correct course of action to take.
Other related posts:
