[haiku-commits] haiku: hrev45878 - src/apps/debugger/dwarf
- From: anevilyak@xxxxxxxxx
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 19 Jul 2013 01:08:13 +0200 (CEST)
hrev45878 adds 1 changeset to branch 'master'
old head: f3b8787e915dfe31a80e10693b5cc854de92faeb
new head: a5bee836388067c5e1926ce2f3bd734f47364b2b
overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=a5bee83+%5Ef3b8787
----------------------------------------------------------------------------
a5bee83: DwarfFile: Slight cosmetic change to trace output.
Output the DIE trace for a type unit after we've read the signature and
type offset so we can include those as well.
[ Rene Gollent <anevilyak@xxxxxxxxx> ]
----------------------------------------------------------------------------
Revision: hrev45878
Commit: a5bee836388067c5e1926ce2f3bd734f47364b2b
URL: http://cgit.haiku-os.org/haiku/commit/?id=a5bee83
Author: Rene Gollent <anevilyak@xxxxxxxxx>
Date: Thu Jul 18 23:06:27 2013 UTC
----------------------------------------------------------------------------
1 file changed, 14 insertions(+), 11 deletions(-)
src/apps/debugger/dwarf/DwarfFile.cpp | 25 ++++++++++++++-----------
----------------------------------------------------------------------------
diff --git a/src/apps/debugger/dwarf/DwarfFile.cpp
b/src/apps/debugger/dwarf/DwarfFile.cpp
index d0d889d..517c441 100644
--- a/src/apps/debugger/dwarf/DwarfFile.cpp
+++ b/src/apps/debugger/dwarf/DwarfFile.cpp
@@ -1007,9 +1007,21 @@ DwarfFile::_ParseTypesSection()
break;
}
+ dataReader.SetAddressSize(addressSize);
+
+ uint64 signature = dataReader.Read<uint64>(0);
+
+ off_t typeOffset = dwarf64
+ ? dataReader.Read<uint64>(0)
+ : dataReader.Read<uint32>(0);
+
+ off_t unitContentOffset = dataReader.Offset();
+
TRACE_DIE("DWARF%d type unit: version %d, length: %" B_PRIu64
- ", abbrevOffset: %" B_PRIdOFF ", address size: %d\n",
- dwarf64 ? 64 : 32, version, unitLength, abbrevOffset,
addressSize);
+ ", abbrevOffset: %" B_PRIdOFF ", address size: %d, "
+ "signature: %#" B_PRIx64 ", type offset: %" B_PRIu64
"\n",
+ dwarf64 ? 64 : 32, version, unitLength, abbrevOffset,
addressSize,
+ signature, typeOffset);
if (version > 4) {
WARNING("\"%s\": Unsupported type unit version: %d\n",
@@ -1022,15 +1034,6 @@ DwarfFile::_ParseTypesSection()
addressSize);
break;
}
- dataReader.SetAddressSize(addressSize);
-
- uint64 signature = dataReader.Read<uint64>(0);
-
- off_t typeOffset = dwarf64
- ? dataReader.Read<uint64>(0)
- : dataReader.Read<uint32>(0);
-
- off_t unitContentOffset = dataReader.Offset();
// create a type unit object
TypeUnit* unit = new(std::nothrow) TypeUnit(
Other related posts:
- » [haiku-commits] haiku: hrev45878 - src/apps/debugger/dwarf - anevilyak