[haiku-commits] Re: haiku: hrev45856 - src/kits/mail
- From: pulkomandy@xxxxxxxxxxxxx
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sat, 13 Jul 2013 21:29:22 +0200
On 2013-07-13 at 21:04:46 [+0200], John Scipione <jscipione@xxxxxxxxx>
wrote:
> On Sat, Jul 13, 2013 at 2:56 PM, <stpere@xxxxxxxxx> wrote:
> > hrev45856 adds 1 changeset to branch 'master'
> > old head: fffc0e2a7b1798852b7d839614ce6347132003f8
> > new head: 073218a8aeef62ef94d49852f27a9f075bfe53f8
> > overview:
> > http://cgit.haiku-os.org/haiku/log/?qt=range&q=073218a+%5Efffc0e2
> >
> > r.OffsetBy(r.Width() + 5,0);
> > - fBytesLabel = new BStringView(r, "kb", "KB");
> > + fBytesLabel = new BStringView(r, "kb", B_TRANSLATE("KiB"));
> > AddChild(fBytesLabel);
> > fSizeBox->SetDivider(0);
>
> I apologize if this has already been discussed, but, is is really
> necessary to translate units? Aren't they internationalized already?
I was going to comment on this. Please use StringForSize() for converting
values to human-readable strings in a human readable way. This includes
both the unit and the proper number formatting.
--
Adrien.
Other related posts:
