[haiku-commits] haiku: hrev45839 - src/apps/debugger/value

  • From: anevilyak@xxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 10 Jul 2013 04:02:25 +0200 (CEST)

hrev45839 adds 1 changeset to branch 'master'
old head: 25b723638df76e0c47d02a0e1c1b3c3534735189
new head: 8f5729e1b9e1bc1f27a8752eee01792d8c9d3ddf
overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=8f5729e+%5E25b7236

----------------------------------------------------------------------------

8f5729e: Debugger: ValueLoader: Add TODO note.

                                      [ Rene Gollent <anevilyak@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev45839
Commit:      8f5729e1b9e1bc1f27a8752eee01792d8c9d3ddf
URL:         http://cgit.haiku-os.org/haiku/commit/?id=8f5729e
Author:      Rene Gollent <anevilyak@xxxxxxxxx>
Date:        Wed Jul 10 02:00:33 2013 UTC

----------------------------------------------------------------------------

1 file changed, 5 insertions(+)
src/apps/debugger/value/ValueLoader.cpp | 5 +++++

----------------------------------------------------------------------------

diff --git a/src/apps/debugger/value/ValueLoader.cpp 
b/src/apps/debugger/value/ValueLoader.cpp
index 19f3136..9d973eb 100644
--- a/src/apps/debugger/value/ValueLoader.cpp
+++ b/src/apps/debugger/value/ValueLoader.cpp
@@ -122,6 +122,11 @@ ValueLoader::LoadValue(ValueLocation* location, type_code 
valueType,
                uint32 bytesToRead = piece.size;
                uint32 bitSize = piece.bitSize;
                uint8 bitOffset = piece.bitOffset;
+                       // TODO: the offset's ordinal position and direction 
aren't
+                       // specified by DWARF, and simply follow the target 
language.
+                       // To handle non C/C++ languages properly, the 
corresponding
+                       // SourceLanguage will need to be passed in and 
extended to
+                       // return the relevant information.
 
                switch (piece.type) {
                        case VALUE_PIECE_LOCATION_INVALID:


Other related posts:

  • » [haiku-commits] haiku: hrev45839 - src/apps/debugger/value - anevilyak