[haiku-commits] haiku: hrev45747 - src/preferences/backgrounds

  • From: jscipione@xxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 7 Jun 2013 21:55:16 +0200 (CEST)

hrev45747 adds 2 changesets to branch 'master'
old head: 6e6c121b84c609e395642175109ac778a92e6543
new head: 51e2dbe7f2df7178a0e232a69a87795dcd946084
overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=51e2dbe+%5E6e6c121

----------------------------------------------------------------------------

d0ddd79: Backgrounds: Update spacing around preview.
  
  So that there isn't extra space at the bottom, only between the monitor
  and the X and Y text controls, and the insets.

51e2dbe: Backgrounds: AddGlue() before color control
  
  ... so that it is attached to bottom of the box.

                                     [ John Scipione <jscipione@xxxxxxxxx> ]

----------------------------------------------------------------------------

1 file changed, 4 insertions(+), 2 deletions(-)
src/preferences/backgrounds/BackgroundsView.cpp | 6 ++++--

############################################################################

Commit:      d0ddd796b2540fdd66be1bb9797f09f338d38fd8
URL:         http://cgit.haiku-os.org/haiku/commit/?id=d0ddd79
Author:      John Scipione <jscipione@xxxxxxxxx>
Date:        Thu Jun  6 16:37:01 2013 UTC

Backgrounds: Update spacing around preview.

So that there isn't extra space at the bottom, only between the monitor
and the X and Y text controls, and the insets.

----------------------------------------------------------------------------

diff --git a/src/preferences/backgrounds/BackgroundsView.cpp 
b/src/preferences/backgrounds/BackgroundsView.cpp
index 2e3f6a1..5e9118c 100644
--- a/src/preferences/backgrounds/BackgroundsView.cpp
+++ b/src/preferences/backgrounds/BackgroundsView.cpp
@@ -105,7 +105,7 @@ BackgroundsView::BackgroundsView()
 
        previewBox->AddChild(BLayoutBuilder::Group<>()
                .AddGlue()
-               .AddGroup(B_VERTICAL, be_control_look->DefaultItemSpacing() * 2)
+               .AddGroup(B_VERTICAL, 0)
                        .AddGroup(B_HORIZONTAL, 0)
                                .AddGlue()
                                .AddGrid(0, 0, 1)
@@ -121,7 +121,8 @@ BackgroundsView::BackgroundsView()
                                        .End()
                                .AddGlue()
                                .End()
-                       .AddGroup(B_HORIZONTAL, B_USE_DEFAULT_SPACING)
+                       .AddStrut(be_control_look->DefaultItemSpacing() * 2)
+                       .AddGroup(B_HORIZONTAL)
                                .Add(fXPlacementText)
                                .Add(fYPlacementText)
                                .End()

############################################################################

Revision:    hrev45747
Commit:      51e2dbe7f2df7178a0e232a69a87795dcd946084
URL:         http://cgit.haiku-os.org/haiku/commit/?id=51e2dbe
Author:      John Scipione <jscipione@xxxxxxxxx>
Date:        Thu Jun  6 16:38:10 2013 UTC

Backgrounds: AddGlue() before color control

... so that it is attached to bottom of the box.

----------------------------------------------------------------------------

diff --git a/src/preferences/backgrounds/BackgroundsView.cpp 
b/src/preferences/backgrounds/BackgroundsView.cpp
index 5e9118c..9e47910 100644
--- a/src/preferences/backgrounds/BackgroundsView.cpp
+++ b/src/preferences/backgrounds/BackgroundsView.cpp
@@ -196,6 +196,7 @@ BackgroundsView::BackgroundsView()
                        .Add(placementMenuField->CreateMenuBarLayoutItem(), 1, 
1)
                        .Add(fIconLabelOutline, 1, 2)
                        .End()
+               .AddGlue()
                .Add(fPicker)
                .SetInsets(B_USE_DEFAULT_SPACING)
                .View());


Other related posts:

  • » [haiku-commits] haiku: hrev45747 - src/preferences/backgrounds - jscipione