[haiku-commits] Re: haiku: hrev45621 - src/add-ons/kernel/bus_managers/agp_gart src/add-ons/accelerants/intel_extreme headers/private/graphics/intel_extreme headers/private/graphics/radeon_hd src/add-ons/kernel/drivers/graphics/radeon_hd

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 05 May 2013 20:49:32 +0200

Am 05/05/2013 20:32, schrieb Jérôme Duval:
> > -               area_id Map(const char *name, void
> >  *physicalAddress, size_t numBytes,
> > +               area_id Map(const char *name, addr_t
> >  physicalAddress, size_t numBytes,
> Should these be using phys_addr_t instead so that they work properly
> with PAE? Or does it not matter in this case...
I have looked at the vesa driver for reference. Only addr_t is used
there at least.

I think the Intel GART driver would actually benefit from this being phys_addr_t (ie. it should support PAE IIRC).

Bye,
   Axel.


Other related posts: