[haiku-commits] Re: haiku: hrev45604 - src/kits/interface headers/os/interface

  • From: John Scipione <jscipione@xxxxxxxxx>
  • To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
  • Date: Fri, 3 May 2013 10:19:37 -0400

On May 3, 2013, at 10:11 AM, Stephan Aßmus <superstippi@xxxxxx> wrote:

> 
> Am 03.05.2013 um 16:09 schrieb John Scipione <jscipione@xxxxxxxxx>:
> 
>> On May 3, 2013, at 10:01 AM, Rene Gollent <anevilyak@xxxxxxxxx> wrote:
>> 
>>> On Fri, May 3, 2013 at 10:00 AM, John Scipione <jscipione@xxxxxxxxx> wrote:
>>>> It compiled fine but only because ListView.h happened to include all those 
>>>> classes that you need below but it's not a great idea to depend on that. 
>>>> If you explicitly declare the classes you need, which adds almost no 
>>>> compile time, then you allow the possibility of eliminating redundant 
>>>> header includes greatly decreasing compile times.
>>> 
>>> Except that's not going to happen here since BOutlineListView
>>> subclasses BListView, and as such that header's not going away.
>> 
>> Right, but a declaration in a header included by BListView might go away.
> 
> Which would be the point in time to add the declaration where it's needed.

Perhaps I'm off my rocker here but that would make something that should be a 
local change, eliminating a superfluous header into a global change, also 
tracking down all the places that header declaration was depended on by headers 
that include your header.

Other related posts: