[haiku-commits] Re: haiku: hrev45596 - src/kits/interface

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 02 May 2013 20:41:49 +0200

Am 02/05/2013 18:34, schrieb John Scipione:
On Thu, May 2, 2013 at 11:03 AM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
Nice, but did you ever hear that code duplication is a bad thing? If not,
please let me tell you: it is a bad thing! :-)

diff John'sReply BetterReply
--- John'sReply
+++ BetterReply
@@ 0,0 +0,0 @@
 > In my defense these pieces were already repeated, I just didn't change
 > that but I did give the repeated variables descriptive names rather
 > than just 10.0f and 15.0f.
-> I await your patch clearing this up. :)
+> But I'm a good boy and add private functions for this :-)

Did you have something like that in mind? ;-)

Bye,
   Axel.


Other related posts: