[haiku-commits] haiku: hrev45538 - src/kits/network/libnetapi

  • From: stefano.ceccherini@xxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 21 Apr 2013 21:18:45 +0200 (CEST)

hrev45538 adds 1 changeset to branch 'master'
old head: e33233713a601400418a779c930e3478c247ef4e
new head: 4ab260da8074c272e95f13258ee2826fcab1867a
overview: http://cgit.haiku-os.org/haiku/log/?qt=range&q=4ab260d+%5Ee332337

----------------------------------------------------------------------------

4ab260d: Don't leak the socket.
  BNetworkRoster::AddInterface and RemoveInterface did not close
  the socket.

                       [ Stefano Ceccherini <stefano.ceccherini@xxxxxxxxx> ]

----------------------------------------------------------------------------

Revision:    hrev45538
Commit:      4ab260da8074c272e95f13258ee2826fcab1867a
URL:         http://cgit.haiku-os.org/haiku/commit/?id=4ab260d
Author:      Stefano Ceccherini <stefano.ceccherini@xxxxxxxxx>
Date:        Sun Apr 21 19:16:52 2013 UTC

----------------------------------------------------------------------------

1 file changed, 4 insertions(+)
src/kits/network/libnetapi/NetworkRoster.cpp | 4 ++++

----------------------------------------------------------------------------

diff --git a/src/kits/network/libnetapi/NetworkRoster.cpp 
b/src/kits/network/libnetapi/NetworkRoster.cpp
index d847f5a..3171aaf 100644
--- a/src/kits/network/libnetapi/NetworkRoster.cpp
+++ b/src/kits/network/libnetapi/NetworkRoster.cpp
@@ -114,6 +114,8 @@ BNetworkRoster::AddInterface(const char* name)
        if (socket < 0)
                return errno;
 
+       FileDescriptorCloser closer(socket);
+
        ifaliasreq request;
        memset(&request, 0, sizeof(ifaliasreq));
        strlcpy(request.ifra_name, name, IF_NAMESIZE);
@@ -139,6 +141,8 @@ BNetworkRoster::RemoveInterface(const char* name)
        if (socket < 0)
                return errno;
 
+       FileDescriptorCloser closer(socket);
+
        ifreq request;
        strlcpy(request.ifr_name, name, IF_NAMESIZE);
 


Other related posts:

  • » [haiku-commits] haiku: hrev45538 - src/kits/network/libnetapi - stefano . ceccherini